[MULTIPLE BOOKMARK LINES SUPPORT THREAD]

[ao2]

1. Describe the issue

I have lots of bookmarks in the bookmark toolbar section, but only a part of them are shown in the toolbar when enabling bookmarks_toolbar_multiple_lines.css

I checked that either scrolling down to the bottom, or setting:

  --bookmark_items_height: 999px; /* <- bookmark items - line height */
  --bookmark_items_lines: 1; /* <- maximum amount of lines */

only a certain number of bookmarks are shown (95 in my case), not all of them.

2. What should have happened instead?

I would have expected to be able to access all bookmarks in the toolbar after scrolling down to the bottom.

3. Steps to reproduce the issue?

Just enable bookmarks_toolbar_multiple_lines.css and add a lot of bookmarks to the bookmarks toolbar, after a certain point new bookmarks are not shown anymore in the toolbar. They can still be accessed in the bookmarks menu.

5. System information

• OS & OS version: Linux/Debian
• Firefox version: 57.0.3
• Firefox theme / lw-theme: default theme
• This projects settings the issue occurs with: bookmarks_toolbar_multiple_lines.css

Thanks,
Antonio

[Aris-t2]

There might be an internal limit for the maximum amount of visible bookmarks inside "bookmarks item box". This limit does not affect popup menus.

In my tests 110 of 250 bookmarks are visible (on Win7 with Fx59) and it does not matter how many visible lines I set 2, 10 or 20.

After all this is an experimental feature offering something not meant to be available by default.
I will add a note to userChrome.css about this unless this can be resolved somehow.

[ao2]

There might be an internal limit for the maximum amount of visible bookmarks inside "bookmarks item box". This limit does not affect popup menus.

I tried the same userChrome.css in FF55 and the limitation is not there, all bookmarks are visible by scrolling down the toolbar. I'll do some more research and maybe post a bug report to Firefox itself.

[Aris-t2]

In my tests Firefox 52-56 was also free of that limitation. Must be something they introduced in Fx57.

[ao2]

For now I mentioned the problem in https://bugzilla.mozilla.org/show_bug.cgi?id=1420089

[ao2]

The limit on number of items in the bookmarks toolbar has been introduced by https://hg.mozilla.org/mozilla-central/rev/b3a7b5c0618b to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1392081

[Aris-t2]

So there is nothing we can do about. There is no hidden preference to workaround this.

[shogunreaper]

i just started trying to use css and i can't get this one to work

no matter what i change

--bookmark_items_lines: 2;

to the number of lines stays at 3.

is there something else i need to edit?

[Aris-t2]

If you are using the complete release archive of this project, you have to change variables inside \config\general_variables.css.

The variable has also to be inside the actual CSS file for users, that only pick some files of this project without using the whole package.

[shogunreaper]

thanks that worked

is there a way to increase the width of the area used? There's a ton of unused space on the right side near the scrollbar.

[Aris-t2]

Post a screenshot.

This "problem" may be based on the length of your bookmarks and you window width.

You get different results depending on your window width. Look here:

[shogunreaper]

https://i.imgur.com/UaPiCpx.png

looks like it depends on the name of the previous bookmarks, if it's short then it will have a lot of unused space.

[Marcosdw]

/* @import "./css/toolbars/bookmarks_toolbar_multiple_lines.css"; /**/ /* <--- EXPERIMENTAL */

does not work on the latest version Nightly 66
__
Sorry I use an online translator French / English

[Aris-t2]

Thanks for letting us know. (Multiple tab lines v1 also refuses to work on current Nightly builds.)

[Speravir]

Oh, this is mean what a coincedence: I had the idea to test whether a flex or grid layout would help for multiple lines in Fx66, and therefore downloaded a beta version, but faced some other problems more important in the moment to me, so testing didn’t start yet. Now, you come with the same idea, and one advantage of it is I could test the rule: It works great, thank you!

[Marcosdw]

Hello,

I test in Fx66b9 : @import "./css/toolbars/bookmarks_toolbar_multiple_lines_fx66.css";
Work fine but please add scrollbar as in older versions because truncated with 3 lines
Thanks
__
Sorry I use an online translator French / English

[Aris-t2]

This was already fixed by Achille. It will be on next update.

[Marcosdw]

Ok thank you ;)

[ArkadiuszMichalski]

Hello, I have really strange behaviour when use; @import "./css/toolbars/bookmarks_toolbar_multiple_lines_fx66.css";

I use last Nightly 68.a01 and only custom CSS from here (without any addons).

Actually set that options in general_variables.css:

/* for bookmarks_toolbar_multiple_lines.css */
  --bookmark_items_height: 26px !important; /* <- bookmark items - line height */
  --bookmark_items_lines: 3 !important; /* <- maximum amount of lines */

and personal setting in my_userChrome.css:

#personal-bookmarks #PlacesToolbar toolbarbutton.bookmark-item{
  margin-top: 0px !important;
  margin-bottom: 0px !important;
  padding-right: 2px !important;
}

My bookmarks toolbar has 3 line of bookmark. Last line its not full, just half. Problem is when I try opening some url then all items on bookmarks toolbar disappears for short time and then appears. Time from disappears to appears is different (1s or less), and basically I do not know what it depends on (maybe after load URL all items back). Look for that picture:

It's strange because happend not for every URL, but for some of them (and not every time:). And loading this url from bookmark toolbar or URL bar make the same blinking result.

I remember that in past I have the same problem when using Multirow Bookmarks Toolbar Plus extension in new FX version, so I jump to Roomy Bookmarks Toolbar extension and problem dissapears. Has anyone met such behavior and knows how to fix this flashing?

@Aris-t2 any solution? Eventually I will try to import the code from Roomy Bookmarks Toolbar to my uc.js script, but I would prefer a solution in pure CSS (if it's possible).

[Aris-t2]

Haven't seen this glitch here yet.

[ArkadiuszMichalski]

I have this since FX54 or even earlier. It is possible that my set of bookmarks has such a strange behavior, I will try to reproduce it on a clean profile with minimal changes and few tabs (but minimum 2 line). If you would be interested, I would send a link to such a profile, because without it you will never fix it.

Edit1: they don't disappear when I have scroll in bookmarks toolbar (to many bookmarks for 3 line).

Edit2: problem appear when I add some new bookmark to existing bookmark folder. When I restart browser then problem not appear, but still when add next new bookmark to existing folder problem appear until next restart browser.

[Aris-t2]

Sure, share a link with a new test profile uploaded to a share service like Dropbox ( or similar without waiting times, capchas or registrations ;-) ).

Setup Portable Firefox, add the latest files of the project to /chrome/ folder and setup theme, create a bunch of bookmarks..., zip/rar/7z the /profile/ folder and upload it somewhere.

[Pastant]

1. Describe the issue

I have lots of bookmarks in the bookmark toolbar section, but the third row is not completely visible when enabling bookmarks_toolbar_multiple_lines.css:

--bookmark_items_height: 35px; /* <- bookmark items - line height /
--bookmark_items_lines: 4; / <- maximum amount of lines */

doesn't seem to help.

2. What should have happened instead?

Show all three rows without scrolling.

3. Steps to reproduce the issue?

Just enable bookmarks_toolbar_multiple_lines.css and add a lot of bookmarks to the bookmarks toolbar. The third row will not show completely. And multiple tab bars is not compatible with this tweak: ./css/tabs/tabs_multiple_lines_v3.css

5. System information

OS & OS version: Win 7 64 bit
Firefox version: 68.0.1
Firefox theme / lw-theme: default theme

Thanks

[Aris-t2]

As far as I know the combination 'tabs not on top' + 'tabs multiple lines' + 'multiple bookmarks lines' never worked properly.

As a workaround you can try 'tabs_below_navigation_toolbar_fx65_v2.css' + 'tabs_multiple_lines_v3.css' + 'bookmarks_toolbar_multiple_lines_fx66.css'.

[Pastant]

Thanks for the response. The workaround works almost perfect ...

The combination 'tabs not on top' + 'tabs multiple lines' + 'multiple bookmarks lines' worked with FF ESR 60.0.8 properly:

[Aris-t2]

I meant it stopped working perfectly after Mozillas tab changes in Fx65.

[Ghst84]

Hey, guys. I'm a complete noob. Could someone please explain to me how to use this code? I need the exact steps. I updated my Firefox to version 74, to try this out, but I don't know what to do. In case this doesn't work, I will revert back to version 56. Thanks!

[Aris-t2]

Every step how to setup custom CSS files is mentioned on main page.
https://github.com/Aris-t2/CustomCSSforFx

I suggest to start using the complete package and enable/disable features you need to get basic understanding how everything works.

[KathrynBassett]

New computer (Win10), new installation of Firefox (77.0.1), new install of CustomCSSforFx. Imported my bookmarks by synching FF. On existing computer (Win8.1) FF (76.0.1), I have my 6 rows of bookmarks working fine. Most CSS files dated 5 Feb 2020, don't know what version of CustomCSSforFx that is. But new computer doesn't show multiple lines of bookmarks, not even the default 3 lines in the package. It shows one line, then the >>> to see the continuation.

UserChrome says "bookmarks toolbar multiple lines' is not compatible with Firefox 66+" but that's not true as it works on my old computer. Both userChromes are identical as I copied the one from old computer to new computer.

What do I need to do to get my bookmarks to show more than one line?

[Aris-t2]

bookmarks_toolbar_multiple_lines_fx74.css works for me too (up to Fx79).

Test on a new browser profile using latest files.

Edit
about:support >Application Basics > Profile Folder > Open Folder

Backup everything, restart Firefox.
(Or just start by backing up chrome folder and extract latest release of this projects files there).

Like bmazak said, verify your Firefox loads this projects files correctly:
'about:config > toolkit.legacyUserProfileCustomizations.stylesheets > true'

[KathrynBassett]

Test on a new browser profile using latest files.

Putting all the steps in case someone else runs across my problem, and so I can have the steps to follow them on a friend's computer who is having the same problem.

Made new profile. I know I'm using the new one because it's very basic.

Logged in to Firefox so I could sync to get my bookmarks.

Closed FF

Copied the contents of custom_css_for_fx_v3.1.4_v3 to the new chrome folder.

Removed /* from @import "./css/toolbars/bookmarks_toolbar_multiple_lines_fx74.css" in userChrome.css in chrome folder. (Caution: I had fx66 edited out in one try, which might have been the problem all along).

Opened FF and changed about:config > toolkit.legacyUserProfileCustomizations.stylesheets >to true

Closed and reopened FF and IT WORKS!!!

[KathrynBassett]

New question: In bookmarks_toolbar_multiple_lines_fx74.css, I changed the 3 to 6 for number of rows. It will "scroll" 6 rows, but how do I "see" all 6 rows? Do I need to change it someplace else as well?

[bmazak]

The CSS code is the data. I have scrollable 4 lines so try my code once and see if that helps.

[Aris-t2]

@KathrynBassett
If you are using the complete package, variables are set inside /config/general_variables.css

https://github.com/Aris-t2/CustomCSSforFx/blob/master/classic/config/general_variables.css#L36

@bmazak
Please do not respond via email, come to Github ( #99 ). Otherwise your posts contain quotes and other non-required content making this thread unreadable.

[KathrynBassett]

If you are using the complete package, variables are set inside /config/general_variables.css

Got it changed, and I'm getting my six rows, but it's spreading into a gray area:

[Aris-t2]

Six rows is too much for that theme. Try fewer rows or a different theme.

[KathrynBassett]

4 worked. I'll experiment later with other themes to get my 6 rows. I'll live with scrolling in the meantime.

Is there a specific place you have a list of some of the more common things people do? I think the only thing I have left is getting the tabs below the bookmarks toolbar, but you never know.

[Aris-t2]

No there is no list like that.

Main feutures always have been squared tabs, application button in titlebar and tabs below navigation/bookmarks toolbar.

[KathrynBassett]

Phooey! I implemented tabs_below_navigation and that breaks the multiple bookmarks, putting it back to one line with the >> at the end of the row. How can I have both?

[Aris-t2]

https://github.com/Aris-t2/CustomCSSforFx/blob/master/classic/userChrome.css#L341
https://github.com/Aris-t2/CustomCSSforFx/blob/master/classic/userChrome.css#L350

[KathrynBassett]

I took out the /* before these two lines
@import "./css/tabs/tabs_below_navigation_toolbar_fx74.css"; // /* Kathryn edited */
@import "./css/toolbars/bookmarks_toolbar_multiple_lines_fx74.css"; // /* <--- EXPERIMENTAL Kathryn edited*/ /Fx74+/

Still not working, so what did I do wrong? Also, is there a specific way I should add my name in the notes so it doesn't mess things up? Is that my problem? Notepad doesn't give line numbers, so I can't give you that, but they were in the area of lines 341 and 350 that you referenced. Adding my name is best way for me to find changes quickly.

[KathrynBassett]

Started over again, and left out the notes about what I edited, and it's working now. I can only guess I added the Kathryn edited comment in wrong format. But since I have the lines here, I can refer to them in the future.

[Aris-t2]

@KathrynBassett
I suggest using a more professional editor like Notepad++ to edit files. It offers line numbers, code highlighting and tons of other feature default Notepad does not offer.

[KathrynBassett]

Thanks for the suggestion. I'd heard of Notepad++ but didn't know why people used it. It's now downloaded, installed, and available from the right click "open with" menu. The line numbers referred to above that I've commented out line, are 360 (tabs below navigation), and 644 (multiple lines).

Last question is actually for a different thread, but still pertinent here: what is the proper way to add a comment to a line - in these cases, adding "Kathryn edited" so I can find things that I changed versus them being default. I'm pretty sure I did it wrong at one point, which is why it "broke". Everything is working now, but I want to go back and add my comments.

I can just add /* Kathryn commented out the line below/ above a particular line. Only downside I see, is that it throws off the line numbers when referring to them in a thread. I'd rather understand the quantity of / and * spaces needed to add something to the end of the line.

And curiosity only, why the comment experimental, even when something is being used?

[Aris-t2]

Every line has a /**/ where you can add any comment without affecting the code. It should look like this /* comment */.

[Aris-t2]

I think this does not need an own discussion anymore.
Use main thread: #454