Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StaticProblem: don't display as incorrect until you reach a leaf node #168

Open
dfannius opened this issue May 14, 2017 · 2 comments
Open

Comments

@dfannius
Copy link

In my problems, I often want to play out an incorrect sequence to the end, to make it more obvious why it is a failure. glift's static problem controller displays a red X as soon as there is no path to a successful node. I would like to make it not display the failure state until a leaf node is reached. This is easy enough to do in code (I already have it in my local version) but perhaps could be an option.

@artasparks
Copy link
Owner

This is easy to do, but incompatible with the current behavior. How about an option?

@dormerod
Copy link

dormerod commented May 15, 2017

This is a suggestion that came up on Go Game Guru fairly often too. My feeling based on comments there is that most people want to play to the end of a variation before getting feedback and that the early feedback really irritated some users.

An option sounds like a good compromise -- I seem to recall that Josh had some well thought out reason for doing it the other way(?) but can't remember what it was right now.

artasparks added a commit that referenced this issue May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants