Tab sequence can not be controlled in forms which include prettycheckable

[aimfeld]

I use forms with some prettycheckable elements and some other elements. Tabbing through my form used to work, but now I need to set a tabindex value for every element to control the tab sequence. However, as soon as I set the tabindex value on my form elements, prettycheckable elements are not included in the tab sequence anymore (tested with Chrome). There is just no way to control the tab sequence in forms which include prettycheckable elements...

[arthurgouveia]

@aimfeld thanks for pointing this out. Do you have a live URL where I can check this?

Also, is this something you would be able to fix on the plugin?

Thanks.

[aimfeld]

I set up a jsFiddle to test this: http://jsfiddle.net/aZLSA/2/

If you put the cursor on the input field and then tab through the elements, you'll see that the tab sequence defined by the tabindex values is not working.

I had a look at your code but I don't know how to fix this..

[arthurgouveia]

I see the issue.

I won't be able to have any time to work on this until mid September.

If you want to give it a shot, you would need to scan the cloned input for it's attributes and if exists a "tabindex", it should be cloned to the anchor tag that works as the style input.

[markushausammann]

Did you solve this too with 2.0 ?

[markushausammann]

Doesn't seem so, looking at the code.

[arthurgouveia]

Not yet. I'll work on having all properties of the input cloned to the wrapping div.

[arthurgouveia]

@aimfeld maybe you can clone the tabindex attribute from the input/label and set it on the anchor tag that "replaces" the input.

Are you willing to make a PR with this?

[aimfeld]

We have experienced a variety of problems with pretty checkable. We needed to introduce quite a few javascript and css special cases for pretty checkable in our codebase. We are currently in a frontend refactoring process (twitter bootstrap 3) and we will evaluate a css-only solution for radio buttons and checkboxes. If we decide to give pretty checkable another try, I'll let you know. It's hard to let pretty checkable go, it really does look pretty :).

[arthurgouveia]

Next time I touch this plugin, I'm thinking of getting rid of the images on the background and simply have the anchor tag look like the checkable container and add a :before pseudo selector to style the checkmark on both cases.

Second thing is getting rid of the jQuery dependency.

Let me know.