Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i cannot see tp, fc, de on the profile after the roast #1323

Closed
yarino25 opened this issue Nov 27, 2023 · 12 comments
Closed

i cannot see tp, fc, de on the profile after the roast #1323

yarino25 opened this issue Nov 27, 2023 · 12 comments
Labels
Milestone

Comments

@yarino25
Copy link

Describe the bug
i cannot see tp, fc, de marks
on the profile after the roast
only the charge in appearance

Screenshots
צילום מסך 2023-11-27 ב-18 50 04

Setup (please complete the following information):

  • Artisan Version [e.g. v2.4.4]: 2.8.4
  • Artisan Build (number in brackets shown in the about box) [e.g. 97e6dec]: ac17fbe
  • Platform (Mac/Windows/Linux + OS version) [e.g. macOS 10.15.3]: mac
  • Connected devices or roasting machine [e.g. Probatone 5]: phidget 2xrtd

Please attach your current Artisan settings file (as exported via menu Help >> Save Settings as *.aset) file.
Please attach any relevant Artisan *.alog profiles.
yarino 25.aset.zip

Note that you need either add a .txt extension or zip the files before uploading. Otherwise you will receive a "Not a supported file type" error on uploading.

@MAKOMO
Copy link
Member

MAKOMO commented Nov 27, 2023

Could you please also attach the profile shown in that linked screen shot (btw. you could have just drag-drop that screenshot here on a comment box to have it inline).

Please rename the *.alog file to end in *.txt or zip it before you drag-drop it here on GitHub to a comment box. A reply by email will not work!

@yarino25
Copy link
Author

צילום מסך 2023-11-27 ב-22 53 39

@yarino25
Copy link
Author

yarino 25.txt

is that work?
thanks!!

@MAKOMO
Copy link
Member

MAKOMO commented Nov 27, 2023

You uploaded the settings file again. The Artisan profile ending .alog is missing. Please upload that in the same way by renaming it to *.txt.

@yarino25
Copy link
Author

@MAKOMO
Copy link
Member

MAKOMO commented Nov 27, 2023

Loaded your settings and your profile in Artisan v2.8.4 and it works for me. All annotations are visible.

Screenshot 2023-11-27 at 22 15 18

@yarino25
Copy link
Author

so what could be the reason sone that it not visible ?

@yarino25
Copy link
Author

ok
i try to change the language from Hebrew to english and it works
so the problem is in the hebrew language

@MAKOMO
Copy link
Member

MAKOMO commented Nov 27, 2023

I can reproduce this now. Will try to fix it.... Thanks a lot for reporting!

@Terracotta-6
Copy link

ef4859dc8c572c7f90b635a3042f62c

@MAKOMO MAKOMO added the bug label Nov 28, 2023
@MAKOMO MAKOMO added this to the v2.10.0 milestone Nov 28, 2023
@MAKOMO
Copy link
Member

MAKOMO commented Nov 28, 2023

What is this screenshot about?

@MAKOMO
Copy link
Member

MAKOMO commented Nov 28, 2023

Fixed by Commit f613f77. This was indeed a language specific issue. Our graphing lib does not support right-to-left languages like Hebrew out of the box thus we need to reverse characters in our code. There was an issue related to argument substitution in that code. The fix will be in the next Artisan release v2.10 to be released later today.

Screenshot 2023-11-28 at 08 23 09

In case you see Hebrew translation issues, please report them separately!

@MAKOMO MAKOMO closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants