Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The error found when setting Filters. #1406

Closed
fwrowe opened this issue Jan 20, 2024 · 1 comment
Closed

The error found when setting Filters. #1406

fwrowe opened this issue Jan 20, 2024 · 1 comment
Milestone

Comments

@fwrowe
Copy link

fwrowe commented Jan 20, 2024

I noticed that when setting the Filters, the numerical values for Celsius and Fahrenheit are identical, with only the units changing. This default setting is not user-friendly and has caused me confusion.I am not sure about the meaning of these default values, whether they are in Fahrenheit or Celsius, or what values would be better to change them to.

I look forward to your prompt attention to this matter.
The error found when setting Filters

@MAKOMO MAKOMO added this to the v2.10.2 milestone Feb 17, 2024
@MAKOMO
Copy link
Member

MAKOMO commented Feb 17, 2024

The input filter min/max limits don't carry a unit as they are applied directly to the readings received independent if those are in C, F, Volt, Amper,... Therefore those limits are not adjusted based on the temperature unit selected and the filter is deactivated by default (not ticked as in your screenshots) as this filter should only be applied if absolutely needed and can lead to confusing situations otherwise.

The values of the "Interpolate Duplicates" input filter as well as the RoR min/max limits should be adjusted on changing the temperature unit. This will be added to the next Artisan version. Thanks for your report!

Fixed in commit 8807ac1.

@MAKOMO MAKOMO closed this as completed Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants