Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File name becomes empty when it's in Chinese. #869

Closed
figoluo opened this issue Apr 20, 2022 · 5 comments
Closed

File name becomes empty when it's in Chinese. #869

figoluo opened this issue Apr 20, 2022 · 5 comments
Milestone

Comments

@figoluo
Copy link

figoluo commented Apr 20, 2022

Describe the bug
When I type the title in Chinese, the auto-save file's name would be empty.
A clear and concise description of what the bug is.

Expected behavior
Hope the file's name can be auto saved in Chinese.

Screenshots
image
image

Setup (please complete the following information):

  • Artisan Version [v2.6.0]:
  • Platform[macOS 12.0.1]:
@MAKOMO MAKOMO added this to the v2.6.2 milestone May 2, 2022
@MAKOMO
Copy link
Member

MAKOMO commented May 2, 2022

Artisan never supported no-ascii chars in filenames. We plan to add support for general unicode characters to the next release. Thanks for the suggestion.

@MAKOMO
Copy link
Member

MAKOMO commented May 13, 2022

Support for filenames with unicode characters has been added in Commit fc50b49.

This is available in the beta version 2.6.1 which is available here:
https://github.com/artisan-roaster-scope/artisan/releases/tag/continuous

Could you please test this and give us feedback?

@ID-JerryChen
Copy link

Makomo Thank you, the result of my test here is ok
截圖 2022-06-25 18 59 15

@ID-JerryChen
Copy link

There is another error
cause the text to not display properly

截圖 2022-06-25 19 03 07

MAKOMO added a commit that referenced this issue Jul 14, 2022
- fixes issue with Chinese characters in Analyzer results annotation boxes (Issue #869)
@MAKOMO
Copy link
Member

MAKOMO commented Jul 14, 2022

Thanks for testing/confirming the original issue and reporting also this new issue. The monospace font used here did not feature Chinese characters. Just replaced the font here such that this should display fine now also with Chinese characters.

@MAKOMO MAKOMO closed this as completed Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants