Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some chords don't appear correctly #101

Open
andrelopespereira opened this issue May 26, 2020 · 6 comments
Open

Some chords don't appear correctly #101

andrelopespereira opened this issue May 26, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@andrelopespereira
Copy link

Describe the bug
In some unusual chords, it shows a "empty" figure.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a music
  2. Click on the chord
  3. See a "empty" figure

Expected behavior
The correct chord is shown on the figure.

Smartphone (please complete the following information):

  • Device: Samsung S10e
  • OS: Android 10
  • App Version: 0.3.1

Screenshots
chord

@artutra
Copy link
Owner

artutra commented May 26, 2020

Could you write here the chorpro text that is causing this?

@andrelopespereira
Copy link
Author

But th[C]is is not all[G]owed
You're uninv[D]ited
{comment:  [Dº] [D] (baixo com primeira nota da tríade)}
An unfortunate slight

The chord would be:
20200526_120440

@artutra
Copy link
Owner

artutra commented May 26, 2020

I guess I found the bug. That is 2 ways to write this circle character:
° and º
I will automatically convert one to another by code on the next version.
Thanks!

@andrelopespereira
Copy link
Author

There's others notations to look. For example:

Em7/5- seems to be missing on the chord set
Bdim shows a blank tab too
20200526_121531

@andrelopespereira
Copy link
Author

ChordPro text:

Moça bon[Em7/5-]ita, seu [A7]olho br[Dm]ilha
(...)
Ou é só br[Bdim]ilho femin[C]ino

@artutra
Copy link
Owner

artutra commented May 26, 2020

In this case the chord Bdim is actually missing, but it is strange with Em7/5-, I can find it on the database

@artutra artutra added the bug Something isn't working label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants