Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom chords #115

Open
artutra opened this issue Jun 4, 2020 · 3 comments
Open

Create custom chords #115

artutra opened this issue Jun 4, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@artutra
Copy link
Owner

artutra commented Jun 4, 2020

No description provided.

@artutra artutra added the enhancement New feature or request label Jun 4, 2020
@faniry6
Copy link

faniry6 commented Jun 11, 2020

As given here https://www.chordpro.org/chordpro/Directives-define.html one can define chord manually in the chordpro file. But I guess you thought about editing manually the chord svg by moving the dots?

One thing I do not have any idea how to solve is the transpose problem. Should it be transposed?

@artutra
Copy link
Owner Author

artutra commented Jun 12, 2020

First, no, I believe that the custom chord should not be transposed. If the song is transposed it will show the chords from the database again until you customise the new transposed chord.

About SVG, I intend to create an UI for every metadata of the chordpro specification (such as capo, tunning, tempo, custom chord definition, etc) so, to create a custom chord specification you should:

  • add a new property to Song model with an array of custom chords
  • modify ChordTab component to look for a custom chord first and only after look at the chord database
  • create a new screen to any user be able to edit a chord with visual feedback

I am still creating a button to import .chordpro files on the Settings tab, but after I complete it, we should look for the best way to parse the chordpro text and extract the custom chords from it

@faniry6
Copy link

faniry6 commented Jun 13, 2020

Having these features would be amazing 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants