/
BuildType.cmake
452 lines (366 loc) · 14.6 KB
/
BuildType.cmake
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
include(CompileCheck)
if(NOT CMAKE_VERSION VERSION_LESS 2.8.6)
include(CheckCXXSymbolExists)
check_cxx_symbol_exists(_LIBCPP_VERSION "cstddef" IS_LIBCXX)
else()
set(IS_LIBCXX OFF)
endif()
option(DEBUG_EXTRA "Expensive debug options" OFF)
option(SET_WARNING_FLAGS "Adjust compiler warning flags" ON)
option(SET_NOISY_WARNING_FLAGS "Enable noisy compiler warnings" OFF)
option(SET_OPTIMIZATION_FLAGS "Adjust compiler optimization flags" ON)
set(conservative_warnings)
set(enable_rtti)
set(disable_libstdcxx_debug)
if(MSVC)
if(USE_LTO)
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /GL")
set(CMAKE_EXE_LINKER_FLAGS_RELEASE "${CMAKE_EXE_LINKER_FLAGS_RELEASE} /LTCG")
set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "${CMAKE_SHARED_LINKER_FLAGS_RELEASE} /LTCG")
set(CMAKE_STATIC_LINKER_FLAGS_RELEASE "${CMAKE_STATIC_LINKER_FLAGS_RELEASE} /LTCG")
endif()
if(FASTLINK)
# Optimize for link speed in developer builds
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /DEBUG:FASTLINK")
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /DEBUG:FASTLINK")
elseif(SET_OPTIMIZATION_FLAGS)
# Merge symbols and discard unused symbols
set(CMAKE_EXE_LINKER_FLAGS_RELEASE "${CMAKE_EXE_LINKER_FLAGS_RELEASE} /OPT:REF /OPT:ICF")
set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "${CMAKE_SHARED_LINKER_FLAGS_RELEASE} /OPT:REF /OPT:ICF")
endif()
if(SET_WARNING_FLAGS AND NOT SET_NOISY_WARNING_FLAGS)
# Disable deprecation warnings
add_definitions(-D_CRT_SECURE_NO_WARNINGS)
add_definitions(-D_CRT_NONSTDC_NO_DEPRECATE)
add_definitions(-D_SCL_SECURE_NO_WARNINGS)
# TODO TEMP - disable very noisy warning
# Conversion from 'A' to 'B', possible loss of data
add_definitions(/wd4244)
add_definitions(/wd4267)
# warning C4456: declaration of 'xxx' hides previous local declaration
add_definitions(/wd4456) # TODO triggers on nested BOOST_FOREACH, remove after moving to C++11
# warning C4459: declaration of 'xxx' hides global declaration
add_definitions(/wd4459) # TODO triggers on BOOST_SCOPE_EXIT, remove after moving to C++11
if(MSVC_VERSION LESS 1910)
# warning C4100: 'xxx': unreferenced formal parameter
add_definitions(/wd4100) # has false positives
endif()
# warning C4127: conditional expression is constant
add_definitions(/wd4127)
# warning C4201: nonstandard extension used: nameless struct/union
add_definitions(/wd4201) # used in GLM
if(MSVC_VERSION LESS 1900)
# warning C4250: 'xxx': inherits 'std::basic_{i,o}stream::...' via dominance
add_definitions(/wd4250) # harasses you when inheriting from std::basic_{i,o}stream
endif()
# warning C4324: 'xxx': structure was padded due to alignment specifier
add_definitions(/wd4324)
if(MSVC_VERSION LESS 1900)
# warning C4503: 'xxx': decorated name length exceeded, name was truncated
add_definitions(/wd4503)
# warning C4512: 'xxx' : assignment operator could not be generated
add_definitions(/wd4512) # not all classes need an assignment operator...
endif()
# warning C4701: potentially uninitialized local variable 'xxx' used
add_definitions(/wd4701)
# warning C4703: potentially uninitialized local pointer variable 'xxx' used
add_definitions(/wd4703)
if(MSVC_VERSION LESS 1900)
# warning C4718: 'xxx' : recursive call has no side effects, deleting
add_definitions(/wd4718) # warns in Qt
endif()
endif()
if(WERROR)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /WX")
endif()
if(NOT DEBUG_EXTRA)
add_definitions(-D_HAS_ITERATOR_DEBUGGING=0)
add_definitions(-D_SECURE_SCL=0)
add_definitions(-D_SECURE_SCL_THROWS=0)
add_definitions(-D_ITERATOR_DEBUG_LEVEL=0)
endif()
if(SET_OPTIMIZATION_FLAGS)
# Enable exceptions
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /EHsc")
# Disable RTTI
add_definitions(/GR-) # No RTTI
foreach(flag_var CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE)
string(REGEX REPLACE "/GR( |$)" "" ${flag_var} "${${flag_var}}")
set(${flag_var} "${${flag_var}} /GR-")
endforeach(flag_var)
list(APPEND enable_rtti /GR)
endif()
foreach(flag_var CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE)
# Disable Run time checks
if(NOT DEBUG_EXTRA)
string(REGEX REPLACE "(^| )/RTC1( |$)" "\\1" ${flag_var} "${${flag_var}}")
endif()
# Change runtime library from "Multi-threaded Debug DLL" to "Multi-threaded DLL"
if(NOT DEBUG_EXTRA)
string(REGEX REPLACE "(^| )/MDd( |$)" "\\1" ${flag_var} "${${flag_var}}")
set(${flag_var} "${${flag_var}} /MD")
set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreadedDLL")
endif()
# Remove definition of _DEBUG as it might conflict with libs we're linking with
string(REGEX REPLACE "(^| )/D_DEBUG( |$)" "\\1" ${flag_var} "${${flag_var}}")
if(DEBUG)
string(REGEX REPLACE "(^| )/DNDEBUG( |$)" "\\1" ${flag_var} "${${flag_var}}")
else()
set(${flag_var} "${${flag_var}} /DNDEBUG")
endif()
# Force compiler warning level
if(SET_WARNING_FLAGS)
string(REGEX REPLACE "(^| )/W[0-4]( |$)" "\\1" ${flag_var} "${${flag_var}}")
set(${flag_var} "${${flag_var}} /W4")
endif()
endforeach(flag_var)
if(NOT MSVC_VERSION LESS 1900)
add_definitions(/utf-8)
endif()
# Turn on standards compliant mode
# /Za is not compatible with /fp:fast, leave it off
if(NOT MSVC_VERSION LESS 1910)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /permissive-")
# /permissive- enables /Zc:twoPhase which would be good if two phase lookup wasn't still broken in VS 2017
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Zc:twoPhase-")
endif()
if(NOT MSVC_VERSION LESS 1900)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Zc:inline")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Zc:throwingNew")
endif()
if(NOT MSVC_VERSION LESS 1914)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Zc:__cplusplus")
endif()
# Avoid warning during link
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /NODEFAULTLIB:LIBCMT")
# Always build with debug information
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Zi")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /DEBUG")
# Enable compiler optimization in release
set(CMAKE_CXX_FLAGS_RELEASE
"${CMAKE_CXX_FLAGS_RELEASE} /Ox /Oi /Ot /GS- /fp:fast")
else(MSVC)
if(USE_LDGOLD)
add_ldflag("-fuse-ld=gold")
endif()
if(USE_LTO)
add_cxxflag("-flto=auto")
if(NOT FLAG_FOUND)
add_cxxflag("-flto")
endif()
# TODO set CMAKE_INTERPROCEDURAL_OPTIMIZATION instead
add_ldflag("-fuse-linker-plugin")
endif()
if(FASTLINK)
# Optimize for link speed in developer builds
add_cxxflag("-gsplit-dwarf")
elseif(SET_OPTIMIZATION_FLAGS)
# Merge symbols and discard unused symbols
add_ldflag("-Wl,--gc-sections")
add_ldflag("-Wl,--icf=all")
add_cxxflag("-fmerge-all-constants")
endif()
if(SET_WARNING_FLAGS)
# GCC or Clang (and compatible)
add_cxxflag("-Wall")
add_cxxflag("-Wextra")
add_cxxflag("-Warray-bounds=2")
add_cxxflag("-Wcast-qual")
add_cxxflag("-Wcatch-value=3")
add_cxxflag("-Wdocumentation")
add_cxxflag("-Wdouble-promotion")
add_cxxflag("-Wduplicated-cond")
add_cxxflag("-Wextra-semi")
add_cxxflag("-Wformat=2")
add_cxxflag("-Wheader-guard")
add_cxxflag("-Winit-self")
add_cxxflag("-Wkeyword-macro")
add_cxxflag("-Wlogical-op")
add_cxxflag("-Wmissing-declarations")
add_cxxflag("-Wnoexcept")
add_cxxflag("-Woverflow")
add_cxxflag("-Woverloaded-virtual")
add_cxxflag("-Wpessimizing-move")
add_cxxflag("-Wpointer-arith")
add_cxxflag("-Wredundant-decls")
add_cxxflag("-Wreserved-id-macro")
add_cxxflag("-Wshift-overflow")
add_cxxflag("-Wstrict-null-sentinel")
add_cxxflag("-Wstringop-overflow=2")
add_cxxflag("-Wundef")
add_cxxflag("-Wunused-const-variable=1")
add_cxxflag("-Wunused-macros")
add_cxxflag("-Wvla")
add_cxxflag("-Wliteral-conversion") # part of -Wconversion
add_cxxflag("-Wbool-conversion") # part of -Wconversion
add_cxxflag("-Wfloat-conversion") # part of -Wconversion
add_cxxflag("-Wstring-conversion") # part of -Wconversion
add_cxxflag("-Wenum-conversion") # part of -Wconversion
if(NOT UNITY_BUILD)
add_cxxflag("-Wheader-hygiene")
endif()
if(NOT CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.8)
add_cxxflag("-Wsign-promo")
add_cxxflag("-Wold-style-cast")
if(FLAG_FOUND AND NOT SET_NOISY_WARNING_FLAGS)
list(APPEND conservative_warnings "-Wno-old-style-cast")
endif()
endif()
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5
AND NOT SET_NOISY_WARNING_FLAGS)
# In older GCC versions this warning is too strict
elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5
AND NOT SET_NOISY_WARNING_FLAGS)
# In older Clang verstions this warns on BOOST_SCOPE_EXIT
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Intel" AND NOT SET_NOISY_WARNING_FLAGS)
# For icc this warning is too strict
else()
add_cxxflag("-Wshadow")
endif()
if(SET_NOISY_WARNING_FLAGS OR NOT CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR NOT CMAKE_SIZEOF_VOID_P EQUAL 4)
# TODO for some reason this warns in /usr/include/boost/type_traits/alignment_of.hpp for -m32 builds
add_cxxflag("-Wduplicated-branches")
endif()
if(DEBUG_EXTRA)
# Address sanitizer cannot be linked into shared libraries so there will be undefined symbols
# This is by design as asan needs to be preloaded for shared libraries
else()
add_ldflag("-Wl,--no-undefined")
endif()
if(SET_NOISY_WARNING_FLAGS)
# These are too noisy to enable right now but we still want to track new warnings.
# TODO enable by default as soon as most are silenced
add_cxxflag("-Wconditionally-supported") # warns on casting from pointer to function pointer
add_cxxflag("-Wconversion") # very noisy
# add_cxxflag("-Wsign-conversion") # part of -Wconversion
# add_cxxflag("-Wshorten-64-to-32") # part of -Wconversion
add_cxxflag("-Wstrict-aliasing=1") # has false positives
add_cxxflag("-Wuseless-cast") # has false positives
add_cxxflag("-Wsign-promo")
# add_cxxflag("-Wnull-dereference") not that useful without deduction path
# Possible optimization opportunities
add_cxxflag("-Wdisabled-optimization")
add_cxxflag("-Wpadded")
add_cxxflag("-Wunsafe-loop-optimizations")
# Levels 3 and above may result in warnings for safe code
add_cxxflag("-Wstringop-overflow=4")
if(NOT DEBUG_EXTRA OR NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_ldflag("-Wl,--detect-odr-violations")
endif()
if(UNITY_BUILD)
add_cxxflag("-Wunused-const-variable=2")
endif()
else()
# icc
if(CMAKE_CXX_COMPILER_ID STREQUAL "Intel")
# '... was declared but never referenced'
# While normally a sensible warning, it also fires when a member isn't used for
# *all* instantiations of a template class, making the warning too annoying to
# be useful
add_cxxflag("-wd177")
# 'external function definition with no prior declaration'
# This gets annoying fast with small inline/template functions.
add_cxxflag("-wd1418")
# 'offsetof applied to non-POD (Plain Old Data) types is nonstandard'
# This triggers Qt moc-generated headers
add_cxxflag("-wd1875")
# 'printf/scanf format not a string literal and no format arguments'
# balks when passing NULL as the format string
add_cxxflag("-wd2279")
if(DEBUG)
# 'missing return statement at end of non-void function' even with arx_unreachable()
# ICC does no handle the noreturn attribute with the comma operator
add_cxxflag("-wd1011")
endif()
endif()
# -Wuninitialized causes too many false positives in older gcc versions
if(CMAKE_COMPILER_IS_GNUCXX)
# GCC is 'clever' and silently accepts -Wno-* - check for the non-negated variant
check_compiler_flag(FLAG_FOUND "-Wmaybe-uninitialized")
if(FLAG_FOUND)
add_cxxflag("-Wno-maybe-uninitialized")
else()
add_cxxflag("-Wno-uninitialized")
endif()
endif()
# Xcode does not support -isystem yet
if(MACOS)
add_cxxflag("-Wno-undef")
endif()
endif()
if(IS_LIBCXX)
add_definitions(-D_LIBCPP_ENABLE_NODISCARD)
endif()
endif(SET_WARNING_FLAGS)
if(WERROR)
add_cxxflag("-Werror")
endif()
if(DEBUG_EXTRA)
add_cxxflag("-ftrapv") # to add checks for (undefined) signed integer overflow
add_cxxflag("-fbounds-checking")
add_cxxflag("-fcatch-undefined-behavior")
add_cxxflag("-fstack-protector-all")
add_cxxflag("-fsanitize=address")
# add_cxxflag("-fsanitize=thread") does not work together with -fsanitize=address
add_cxxflag("-fsanitize=leak")
add_cxxflag("-fsanitize=undefined")
if(IS_LIBCXX)
add_definitions(-D_LIBCPP_DEBUG=1) # libc++
# libc++'s debug checks fail with -fsanitize=undefined
else()
add_definitions(-D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC) # libstdc++
set(disable_libstdcxx_debug "-U_GLIBCXX_DEBUG -U_GLIBCXX_DEBUG_PEDANTIC")
endif()
endif(DEBUG_EXTRA)
if(CMAKE_BUILD_TYPE STREQUAL "")
set(CMAKE_BUILD_TYPE "Release")
endif()
if(SET_OPTIMIZATION_FLAGS)
add_cxxflag("-fno-rtti")
if(FLAG_FOUND)
list(APPEND enable_rtti "-frtti")
endif()
if(MACOS)
# TODO For some reason this check succeeds on macOS, but then
# flag causes the actual build to fail :(
else()
# Link as few libraries as possible
# This is much easier than trying to decide which libraries are needed for each
# system
add_ldflag("-Wl,--as-needed")
endif()
foreach(flag_var CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE)
if(DEBUG)
string(REGEX REPLACE "(^| )-DNDEBUG( |$)" "\\1" ${flag_var} "${${flag_var}}")
else()
set(${flag_var} "${${flag_var}} -DNDEBUG")
endif()
endforeach(flag_var)
if(NOT DEBUG AND NOT IS_LIBCXX)
add_cxxflag("-Wp,-U_GLIBCXX_ASSERTIONS")
endif()
if(CMAKE_BUILD_TYPE STREQUAL "Debug")
# set debug symbol level to -g3
check_compiler_flag(RESULT "-g3")
if(NOT RESULT STREQUAL "")
string(REGEX REPLACE "(^| )-g(|[0-9]|gdb)( |$)" "\\1" CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG}")
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} ${RESULT}")
endif()
# disable optimizations
check_compiler_flag(RESULT "-Og")
if(NOT RESULT)
check_compiler_flag(RESULT "-O0")
endif()
string(REGEX REPLACE "(^| )-O[0-9g]( |$)" "\\1" CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG}")
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} ${RESULT}")
elseif(CMAKE_BUILD_TYPE STREQUAL "Release")
if((NOT CMAKE_CXX_FLAGS MATCHES "-g(|[0-9]|gdb)")
AND (NOT CMAKE_CXX_FLAGS_RELEASE MATCHES "-g(|[0-9]|gdb)"))
add_cxxflag("-g2")
endif()
add_cxxflag("-ffast-math")
endif()
endif(SET_OPTIMIZATION_FLAGS)
endif(MSVC)
set(BUILD_TYPES ${CMAKE_CONFIGURATION_TYPES} ${CMAKE_BUILD_TYPE})
list(REMOVE_DUPLICATES BUILD_TYPES)