Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Update wiki/Usage documentation with note that secret credentials will be stored in bash/zsh/etc history #854

Open
henrywintif opened this issue Apr 14, 2024 · 1 comment

Comments

@henrywintif
Copy link

On wiki/Usage the instructions state to pass the client ID and client secret on the command line.

I believe it would be appropriate to add a note that this will most likely add the command (including these secret credentials) to the command history of the shell you are using and perhaps suggest a method to prevent this.

I'm not sure whether bash or zsh default configurations make [space] prepended inputs. My config which isn't very customized does not have this feature enabled.

I just checked and it looks like in ZSH, a user may enable this by running setopt histignorespace, then running the google-drive-ocaml -id ... command with a leading space. After the command is entered they can unset the option with unsetopt histignorespace.

I haven't tested with bash, but it appears that you can use set +o history before and set -o history before and after the command.

@astrada
Copy link
Owner

astrada commented Apr 15, 2024

Feel free to add the tip to the wiki. It's editable by anyone. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants