Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For downstream maintainers: astropy-dev + numpy-dev now also needs pyerfa-dev #15638

Open
pllim opened this issue Nov 21, 2023 · 4 comments
Open
Labels

Comments

@pllim
Copy link
Member

pllim commented Nov 21, 2023

If you start to see errors like this downstream in a job that pulls in astropy 6.1.dev and numpy 2.0.dev:

A module that was compiled using NumPy 1.x cannot be run in
NumPy 2.0.0.dev0 as it may crash. To support both 1.x and 2.x
versions of NumPy, modules must be compiled against NumPy 2.0.

You also need to install pyerfa-dev for that job from https://anaconda.org/liberfa/pyerfa like this:

pip install -U --pre -i https://pypi.anaconda.org/liberfa/simple pyerfa
@bsipocz
Copy link
Member

bsipocz commented Dec 1, 2023

Food for thoughts: make it possible to use and import astropy without pyerfa. E.g. in pyvo we don't use it, yet now we need to make sure we include the dev pyerfa in our testing. Having to dive into dev of indirect dependencies is far from elegant, and the only iers usage I see is to turn off the auto download in conftest 🤦‍♀️

from astropy.utils.iers import conf as iers_conf
iers_conf.auto_download = False

@pllim
Copy link
Member Author

pllim commented Dec 1, 2023

But pyerfa is declared as required runtime dependency. This problem should be rare. I mean, numpy 3.0 won't happen for another 10 years or so, right, right? 😬

@pllim
Copy link
Member Author

pllim commented Dec 1, 2023

For completeness, this is when it became required:

@bsipocz
Copy link
Member

bsipocz commented Dec 1, 2023

Yes, I agree the problem is more a philosophical one, but nevertheless, issues with iers/erfa is coming back often and result in ugly workarounds at each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants