Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research: Newline rendering in Teams messages via Office 365 Connector Cards #58

Open
atc0005 opened this issue Jun 22, 2020 · 2 comments

Comments

@atc0005
Copy link
Owner

atc0005 commented Jun 22, 2020

While researching whether Markdown tables are supported via webhook requests (spoiler: it does not appear so), I stumbled across this line:

In connector cards, newlines are rendered for \n\n, but not for \n or \r.

This is particularly useful to know, as I ended up going this route to work around the discovered behavior:

I don't recall off the top of my head where I learned that <br> was a good replacement, but it served the use case. Now it sounds like the ConvertEOLToBreak() function can be deprecated and one put in its place to substitute \n\n instead.


@atc0005
Copy link
Owner Author

atc0005 commented Aug 30, 2020

Now it sounds like the ConvertEOLToBreak() function can be deprecated and one put in its place to substitute \n\n instead.

Or it can remain, and be adapted to handle replacing a literal single use of \n with \n\n instead of <br>. This would allow the API surface it remain as is.

@atc0005
Copy link
Owner Author

atc0005 commented Aug 30, 2020

Now that recent work has been done to move the formatting functions of this project (atc0005/send2teams) into the atc0005/go-teams-notify project, I think this GH issue will follow suit and move to that project for future work as well.

@atc0005 atc0005 transferred this issue from atc0005/send2teams Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant