Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-way binding broken after 1.0.0-beta.1.0.3 update #264

Closed
michaelmalonenz opened this issue Dec 17, 2015 · 2 comments
Closed

One-way binding broken after 1.0.0-beta.1.0.3 update #264

michaelmalonenz opened this issue Dec 17, 2015 · 2 comments
Labels

Comments

@michaelmalonenz
Copy link
Contributor

After updating to yesterday's release, we found an issue regarding one-way binding. Specifically, if using a getter to compute the value from another object, if the value is undefined (which it must be to show the placeholder) then the literal string undefined is shown in the input. If the binding is changed to two-way (and a setter added, obviously) then the problem disappears.

I have reproduced the problem here:
https://github.com/michaelmalonenz/skeleton-navigation/tree/one-way-binding-bug

@EisenbergEffect
Copy link
Contributor

@jdanyow Seems like a small regression.

@jdanyow
Copy link
Contributor

jdanyow commented Dec 17, 2015

ah yes- will get this fixed. This logic that was added for #152 needs to be added to the static accessor stuff.

@jdanyow jdanyow added the bug label Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants