Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typo in Contact Manager tutorial #450

Open
lion-200 opened this issue Jul 30, 2019 · 4 comments
Open

Minor typo in Contact Manager tutorial #450

lion-200 opened this issue Jul 30, 2019 · 4 comments

Comments

@lion-200
Copy link
Contributor

I'm submitting a minor typo in Contact Manager tutorial documentation

Current behavior:
The file name needs to be created in section Adding Pub/Sub Messaging is called "message.ts" while further in the code of contact-detail.ts "messages" is being imported.

Expected/desired behavior:
Minor change in the file name to be created. From "message.ts" to "messages.ts"

image

@3cp
Copy link
Member

3cp commented Jul 30, 2019

There is no problem for TypeScript to understand that import without extname .ts, same as babel has no problem to understand any import without extname .js.

If you saw some error in your app, either in editor or running app, let's know.

@lion-200
Copy link
Contributor Author

The problem is not the .ts or .js extension, but the name of the module trying to be loaded:

image

The name of the file must be with an "s" added or the imported module must be without the "s" in the end.

@3cp
Copy link
Member

3cp commented Jul 30, 2019

Oh, sorry, I miss read your issue. Send over a PR if you want to :)

@lion-200
Copy link
Contributor Author

No problem :) PR created ;) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants