Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Manager Tut: Building the Application Shell: Minor issues #481

Open
Sidewinder1138 opened this issue Sep 18, 2020 · 0 comments
Open

Comments

@Sidewinder1138
Copy link

Sidewinder1138 commented Sep 18, 2020

First, take a look at the require elements at the top of the view.

Below the require elements, you can see a pretty standard structure.

There is only one require element, so shouldn't be plural.

The router-view is provided by Aurelia and is a placeholder that indicated where the router should render the current route.

Should be "indicates".

There are a few code boxes that are set to 'JavaScript' and cannot be changed to TypeScript. Easy to workaround, but maybe confusing for beginners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant