Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when navigating to route with misconfigured viewPorts #241

Closed
bryanrsmith opened this issue Nov 6, 2015 · 0 comments
Closed

Crash when navigating to route with misconfigured viewPorts #241

bryanrsmith opened this issue Nov 6, 2015 · 0 comments
Assignees
@bryanrsmith
Labels
bug help wanted

Comments

@bryanrsmith
Copy link
Contributor

Configure a view with two viewports and a router with one route that properly configures both viewports and one route that configures only one viewport. Attempting to navigate from the good route to the bad will crash in buildNavigationPlan. We should log a helpful error message.
@bryanrsmith bryanrsmith added the bug label Nov 6, 2015
jwahyoung added a commit to jwahyoung/router that referenced this issue Feb 13, 2016
@jwahyoung
fix(router): log helpful error on missing viewport
a46287f 
When a route does not configure all available viewports, the navigation plan will crash. Now, the navigation plan will log a helpful error with the missing viewport and the affected route.

Fixes aurelia#241.
@jwahyoung jwahyoung mentioned this issue Feb 13, 2016
Merged
jwahyoung added a commit to jwahyoung/router that referenced this issue Feb 13, 2016
@jwahyoung
fix(router): log helpful error on missing viewport
224f5ac 
When a route does not configure all available viewports, the navigation plan will crash. Now, the navigation plan will log a helpful error with the missing viewport and the affected route.

Fixes aurelia#241.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryanrsmith bryanrsmith

Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bryanrsmith