Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript @types/* deps pollute production deps #323

Open
bickelj opened this issue Feb 10, 2023 · 0 comments · May be fixed by #324
Open

TypeScript @types/* deps pollute production deps #323

bickelj opened this issue Feb 10, 2023 · 0 comments · May be fixed by #324

Comments

@bickelj
Copy link

bickelj commented Feb 10, 2023

Description

When adding a dependency on express-jwt, I expected all TypeScript @types dependencies to remain in the devDependencies. Instead, I see several @types dependencies showing up in production dependences. The @types should typically be used at compile-time only.

Reproduction

  1. Add express-jwt to an existing TypeScript project's project.json as a (production/non-dev) dependency and @types/jsonwebtoken as a dev dependency.
  2. npm install
  3. git diff will show that several @types, including @types/jsonwebtoken have their "dev": true flags removed and therefore these packages show up in the production distribution.

Environment

Please provide the following:

  • Version of this library used: "express-jwt": 8.4.1
  • Version of the platform or framework used, if applicable:: npm 8.19.3
  • Other relevant versions (language, server software, OS, browser): node v18.13.0 GNU/Linux
  • Other modules/plugins/libraries that might be involved: jwks-rsa 3.0.1
@bickelj bickelj linked a pull request Feb 10, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant