Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binomial Coefficient: Create data by script #273

Open
PaulXiCao opened this issue Dec 23, 2022 · 0 comments
Open

Binomial Coefficient: Create data by script #273

PaulXiCao opened this issue Dec 23, 2022 · 0 comments

Comments

@PaulXiCao
Copy link
Contributor

The binomial coefficients are hard-coded in autodiff/common/binomialcoefficient.hpp upto order 50. Their correctness is hard to verify.

This data could be computed via some simple python script, e.g. using math.comp or scipy.special.comb.

An example how to accomplish that (create data by script and setup dependencies) is given in the official cmake tutorial.

Possible arguments to consider:

  • large data tables are hard to verify
  • new code needs to be tested and the old seemed to be correct upto now
  • the maximal order could be made variable by a cmake input variable
  • increases complexity in cmake files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant