Skip to content
This repository has been archived by the owner on Feb 8, 2020. It is now read-only.

Broken cache busting of relative CSS paths in HTML #22

Open
ximus opened this issue May 6, 2015 · 2 comments
Open

Broken cache busting of relative CSS paths in HTML #22

ximus opened this issue May 6, 2015 · 2 comments

Comments

@ximus
Copy link

ximus commented May 6, 2015

Hi all, thanks for this gem

I've got a fixed that works well for me: ximus@54a1e68

I wanted to write a spec to test this thoughroughly but ... I wasn't able to run the project specs easily and I had to move one.

If you share with me how, I'm still willing to do it.

my problem case was the folllowing:

I had an HTML file at resume/index.html with a link to a CSS file at ../stylesheets/resume.css. The output CSS path ended up being stylesheets/resume-CACHEBUST.css instead of ../stylesheets/resume-CACHEBUST.css

@avdgaag
Copy link
Owner

avdgaag commented May 7, 2015

I'm not sure I understand exactly why this works. Wouldn't the same fix need to be applied to the following line also?

I don't really use or maintain this project anymore, but if you create a pull request I can have quick look.

@ximus
Copy link
Author

ximus commented May 7, 2015

yeah, sounds like it would.
After my problem was fixed I went to to run the specs in order to produce a proper patch. rspec . failed, i poked around briefly but I couldn't the specs to run.

I didn't have the time or motivation to put more effort into it. Maybe I'll get back to it depending on my work load, no promises.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants