Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove site.create_application from each application #52

Open
MarcSkovMadsen opened this issue Dec 18, 2021 · 0 comments
Open

Remove site.create_application from each application #52

MarcSkovMadsen opened this issue Dec 18, 2021 · 0 comments

Comments

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Dec 18, 2021

Currently each application imports and uses from awesome_panel_extensions.site import site.

image

The the site.create_application adds a lot of code/ overhead to each application.

image

image

This also "forces" us to use pn.serve and I believe panel serve is simpler to use and more supported.

Request

Get rid of site.create_application and @site.add.

Solution

I would suggest a solution where each application is registered in a .yaml file in the exact same way as the awesome_list.yml file.

This file should be used to populate the App Gallery.

We would also have to find a way to populate the menu and info section of each page. Or alternatively give up on that part.
image

Additional Context

We could also just get the long site.create_application part out of each app. Move the registration to the awesome_panel_extensions package or even better a dedicated awesome_panel package. That would make the app simpler but still make it possible to provide meta information and a menu to each app.

@MarcSkovMadsen MarcSkovMadsen changed the title Get rid of awesome_panel_extensions site dependency. Move site.create_application out of each application Dec 18, 2021
@MarcSkovMadsen MarcSkovMadsen changed the title Move site.create_application out of each application Remove site.create_application from each application Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant