Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-cloudfront-s3): support other partitions #1049

Open
biffgaut opened this issue Jan 10, 2024 · 0 comments
Open

fix(aws-cloudfront-s3): support other partitions #1049

biffgaut opened this issue Jan 10, 2024 · 0 comments
Labels
bug Something isn't working needs-triage The issue or PR still needs to be triaged

Comments

@biffgaut
Copy link
Contributor

biffgaut commented Jan 10, 2024

In aws-cloudfront-s3, the partition is hardcoded to aws - https://github.com/awslabs/aws-solutions-constructs/blob/main/source/patterns/%40aws-solutions-constructs/aws-cloudfront-s3/lib/index.ts#L169

While CloudFront support across different partitions varies, there's no reason to limit this construct to a single partition - using the correct partition value here will ensure functionality as other partitions achieve feature parity.

Reproduction Steps

Error Log

Environment

  • CDK CLI Version :
  • CDK Framework Version:
  • AWS Solutions Constructs Version :
  • OS :
  • Language :

Other


This is 🐛 Bug Report

@biffgaut biffgaut added bug Something isn't working needs-triage The issue or PR still needs to be triaged labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage The issue or PR still needs to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant