Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for JupyterHub on EKS solution #515

Open
1 task done
petrokashlikov opened this issue May 2, 2024 · 2 comments
Open
1 task done

Update documentation for JupyterHub on EKS solution #515

petrokashlikov opened this issue May 2, 2024 · 2 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@petrokashlikov
Copy link

Description

Currently if you follow instructions using Cognito authentication and public domain and deploy default code, you won't be able to reach JupyterHub, because in jupyterhub-values-cognito.yaml file NLB annotation is set to make NLB internal. Can you please update documentation to guide users to change that to internet-facing if they go this route.
service.beta.kubernetes.io/aws-load-balancer-scheme: internal

  • ✋ I have searched the open/closed issues and my issue is not listed.

Versions

  • Module version [Required]: latest

  • Terraform version: Terraform v1.7.5

  • Provider version(s):

  • provider registry.terraform.io/hashicorp/archive v2.4.0
  • provider registry.terraform.io/hashicorp/aws v5.47.0
  • provider registry.terraform.io/hashicorp/cloudinit v2.3.4
  • provider registry.terraform.io/hashicorp/helm v2.13.1
  • provider registry.terraform.io/hashicorp/kubernetes v2.29.0
  • provider registry.terraform.io/hashicorp/random v3.1.0
  • provider registry.terraform.io/hashicorp/time v0.11.1
  • provider registry.terraform.io/hashicorp/tls v4.0.5

Reproduction Code [Required]

default code

Steps to reproduce the behavior:

Just follow instructions in documentation to deploy solution with Cognito authentication.

Expected behavior

JupyterHub reachable over public network

Actual behavior

JupyterHub not reachable over public network

@askulkarni2 askulkarni2 added bug Something isn't working documentation Improvements or additions to documentation labels May 2, 2024
@vara-bonthu
Copy link
Contributor

Hi @petrokashlikov, yes, we need to update the documentation for all the blueprints. As part of our security exercise, we have shifted all internet-facing components to internal for ELB.

Could you specify which document you are referring to for JupyterHub in this case? Please post a link here.

@petrokashlikov
Copy link
Author

Hi @vara-bonthu, I'm referring to this one https://awslabs.github.io/data-on-eks/docs/blueprints/ai-ml/jupyterhub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants