osc/phasor has a phase issue

[juhakivekas]

The same input, labeled "freq" is used both in frequency calculations as well as a phase offset. Am I reading the code wrong? Why is the description "phase increment" when that shouldn't be whats happening. This might be copied form other phasor type objects?

"freq" used as phase: https://github.com/axoloti/axoloti-factory/blob/c0f7538e95147586a2040a963d9541c27f2b79e1/objects/osc/phasor.axo#L26
"freq" used as frequency offset: https://github.com/axoloti/axoloti-factory/blob/c0f7538e95147586a2040a963d9541c27f2b79e1/objects/osc/phasor.axo#L24

[jaffasplaffa]

Hey!

There is no phase offset for the osc/phasor object. "freq" is only used for setting the frequency. "Phase" in this context, my guess is, that it refers to the phasor going through a "Phase" from 0-1. "freq" only sets how fast it's going through that phase.

You can check the osc/phasor lin object to see how a phase offset is added. It looks a bit different. You need to add a line or two of code for the phase offset.

So don't put too much into the name of the "Phase" variable, it does not add a phase offset. It's just the name of the variable, it could might as well be called "phasormath", "phasorout", "phasor" or pretty much any name that you can think of.

Hope that clears things up!

Jakob