get_url_file_name: never return a NULL string *and* OK

Change 987a4a7 assumes that as it simplifies life in the calling function. Reported-by: Fabian Keil
curl · Oct 9, 2014 · 199b3e4 · 199b3e4
1 parent 558814e
commit 199b3e4
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/tool_operhlp.c b/src/tool_operhlp.c
@@ -143,11 +143,9 @@ CURLcode get_url_file_name(char **filename, const char *url)
   if(pc) {
     /* duplicate the string beyond the slash */
     pc++;
-    if(*pc) {
-      *filename = strdup(pc);
-      if(!*filename)
-        return CURLE_OUT_OF_MEMORY;
-    }
+    *filename = strdup(pc);
+    if(!*filename)
+      return CURLE_OUT_OF_MEMORY;
   }
 
   /* in case we built debug enabled, we allow an environment variable