Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tests: make sure CRLFs can't be used in URLs passed to proxy
- Loading branch information
Showing
4 changed files
with
109 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
<testcase> | ||
<info> | ||
<keywords> | ||
HTTP | ||
HTTP GET | ||
HTTP proxy | ||
</keywords> | ||
</info> | ||
|
||
# Server-side | ||
<reply> | ||
<connect> | ||
HTTP/1.1 200 OK | ||
We-are: good | ||
|
||
</connect> | ||
|
||
</reply> | ||
# Client-side | ||
<client> | ||
<server> | ||
http | ||
http-proxy | ||
</server> | ||
<tool> | ||
lib1529 | ||
</tool> | ||
<name> | ||
HTTP request-injection in URL sent over proxy | ||
</name> | ||
<command> | ||
"http://the.old.moo:%HTTPPORT/1529" %HOSTIP:%PROXYPORT | ||
</command> | ||
</client> | ||
|
||
# it should be detected and an error should be reported | ||
<verify> | ||
# 3 == CURLE_URL_MALFORMAT | ||
<errorcode> | ||
3 | ||
</errorcode> | ||
</verify> | ||
</testcase> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/*************************************************************************** | ||
* _ _ ____ _ | ||
* Project ___| | | | _ \| | | ||
* / __| | | | |_) | | | ||
* | (__| |_| | _ <| |___ | ||
* \___|\___/|_| \_\_____| | ||
* | ||
* Copyright (C) 1998 - 2014, Daniel Stenberg, <daniel@haxx.se>, et al. | ||
* | ||
* This software is licensed as described in the file COPYING, which | ||
* you should have received as part of this distribution. The terms | ||
* are also available at http://curl.haxx.se/docs/copyright.html. | ||
* | ||
* You may opt to use, copy, modify, merge, publish, distribute and/or sell | ||
* copies of the Software, and permit persons to whom the Software is | ||
* furnished to do so, under the terms of the COPYING file. | ||
* | ||
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY | ||
* KIND, either express or implied. | ||
* | ||
***************************************************************************/ | ||
|
||
#include "test.h" | ||
|
||
#include "memdebug.h" | ||
|
||
int test(char *URL) | ||
{ | ||
CURL *curl = NULL; | ||
CURLcode res = CURLE_FAILED_INIT; | ||
char bURL[512]; | ||
snprintf(bURL, sizeof(bURL), "%s HTTP/1.1\r\nGET http://1529.com/1529", URL); | ||
|
||
if(curl_global_init(CURL_GLOBAL_ALL) != CURLE_OK) { | ||
fprintf(stderr, "curl_global_init() failed\n"); | ||
return TEST_ERR_MAJOR_BAD; | ||
} | ||
|
||
if((curl = curl_easy_init()) == NULL) { | ||
fprintf(stderr, "curl_easy_init() failed\n"); | ||
curl_global_cleanup(); | ||
return TEST_ERR_MAJOR_BAD; | ||
} | ||
|
||
test_setopt(curl, CURLOPT_URL, bURL); | ||
test_setopt(curl, CURLOPT_PROXY, libtest_arg2); | ||
test_setopt(curl, CURLOPT_VERBOSE, 1L); | ||
test_setopt(curl, CURLOPT_PROXYTYPE, CURLPROXY_HTTP); | ||
test_setopt(curl, CURLOPT_HEADER, 1L); | ||
|
||
res = curl_easy_perform(curl); | ||
|
||
test_cleanup: | ||
|
||
curl_easy_cleanup(curl); | ||
curl_global_cleanup(); | ||
|
||
return (int)res; | ||
} |