Skip to content

Commit

Permalink
Thomas Lopatic fixed the alarm()-based DNS timeout
Browse files Browse the repository at this point in the history
  • Loading branch information
bagder committed Mar 22, 2010
1 parent 6657f12 commit d4cd541
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
13 changes: 13 additions & 0 deletions CHANGES
Expand Up @@ -6,6 +6,19 @@

Changelog

Daniel Stenberg (22 Mar 2010)
- Thomas Lopatic fixed the alarm()-based DNS timeout:

Looking at the code of Curl_resolv_timeout() in hostip.c, I think that in
case of a timeout, the signal handler for SIGALRM never gets removed. I
think that in my case it gets executed at some point later on when execution
has long left Curl_resolv_timeout() or even the cURL library.

The code that is jumped to with siglongjmp() simply sets the error message
to "name lookup timed out" and then returns with CURLRESOLV_ERROR. I guess
that instead of simply returning without cleaning up, the code should have a
goto that jumps to the spot right after the call to Curl_resolv().

Kamil Dudka (22 Mar 2010)
- Douglas Steinwand contributed a patch fixing insufficient initialization in
Curl_clone_ssl_config()
Expand Down
3 changes: 2 additions & 1 deletion RELEASE-NOTES
Expand Up @@ -35,6 +35,7 @@ This release includes the following bugfixes:
o TFTP improved error codes
o TFTP fixed TSIZE handling for uploads
o SSL possible double free when reusing curl handle
o alarm()-based DNS timeout bug

This release includes the following known bugs:

Expand All @@ -46,6 +47,6 @@ advice from friends like these:
Steven M. Schweda, Yang Tse, Jack Zhang, Tom Donovan, Martin Hager,
Daniel Fandrich, Patrick Monnerat, Pat Ray, Wesley Miaw, Ben Greear,
Ryan Chan, Markus Duft, Andrei Benea, Jacob Moshenko, Daniel Johnson,
Constantine Sapuntzakis
Constantine Sapuntzakis, Douglas Steinwand, Thomas Lopatic

Thanks! (and sorry if I forgot to mention someone)

0 comments on commit d4cd541

Please sign in to comment.