Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaths are saved in in the Win32 Directory #3

Open
wwboynton opened this issue Oct 27, 2019 · 0 comments
Open

Campaths are saved in in the Win32 Directory #3

wwboynton opened this issue Oct 27, 2019 · 0 comments

Comments

@wwboynton
Copy link

Hey there.

The documentation indicates that the Dollycam path files should be stored in {RL folder}/bakkesmod/data/campaths/filename.json. However, at least as of Bakkesmod 86(? Not sure how to get version, just know I'm running latest and that's the last commit to the SDK repo), the files don't seem to be going here. Instead, I'm finding the files are being saved in {RL folder}Binaries/Win32. Interestingly enough, the files are also being saved without the .json extension.

Despite this, it seems like the plugin is saving/loading paths correctly, so I wouldn't necessarily call this a bug so much as an unexpected/undocumented behaviour.

Starting on line 125 of dollycamplugin.cpp:

	if (command.compare("dolly_path_save") == 0)
	{
		if (params.size() < 2)
		{
			cvarManager->log("Usage: " + params.at(0) + " filename");
			return;
		}
		string filename = params.at(1);
		dollyCam->SaveToFile(filename);

Seems like there's not actually any logic to add the .json extension in the event that the user hasn't provided it (again, that's fine, I think we can expect that anyone who's digging around here probably knows how to open a JSON file without an extension, but for editors with syntax highlighting and other niceties, it might be nice to do it anyway).

It also seems like -- and I don't know jack about C++ so pardon me here -- the working directory context of the plugin might've changed somehow since this commit, due to changes to RL or the Bakkes SDK or whatever, and so now perhaps the subdirectory of ./bakkesmod/data/campaths should be prepended to filename? I'd submit a PR, but I'm afraid I'd just be ignorantly patching a context issue symptom that might need to be handled somewhere else in a more general way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant