Put the new Mongo Pool Size config in sails-mongo

[marecatg]

Node version: 16.20.2
Sails version (sails): - (NestJS App)
ORM hook version (sails-hook-orm): -
Sockets hook version (sails-hook-sockets): -
Organics hook version (sails-hook-organics): -
Grunt hook version (sails-hook-grunt): -
Uploads hook version (sails-hook-uploads): -
DB adapter & version (e.g. sails-mysql@5.55.5): "sails-mongo": "2.1.0"
Skipper adapter & version (e.g. skipper-s3@5.55.5): -
mongodb version : "mongodb": "6.3.0"

---

First I want to thank you very much for updating sails-mongo 🚀❤

Here is the problem :
Error happen when server is starting.

[Nest] 269955   - 03/04/2024, 4:25:33 PM   Invalid configuration for datastore `mongo`:  Unrecognized options (`maxPoolSize`) specified as config overrides.
This adapter expects only whitelisted properties.
--
See http://sailsjs.com/config/datastores#?the-connection-url for info,
or visit https://sailsjs.com/support for more help. +132ms
Error: Invalid configuration for datastore `mongo`:  Unrecognized options (`maxPoolSize`) specified as config overrides.
This adapter expects only whitelisted properties.
--
See http://sailsjs.com/config/datastores#?the-connection-url for info,
or visit https://sailsjs.com/support for more help.
    at Object.registerDatastore (/home/app/application/node_modules/sails-mongo/lib/index.js:209:58)
    at /home/app/application/node_modules/waterline/lib/waterline.js:717:27

See with @DominusKelvin, mongo parameter poolSize is now deprecated, I've replace it by maxPoolSize wich is not reconized by the new release of sails-mongo.

Regards 😃

[sailsbot]

@marecatg Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[DominusKelvin]

Thanks @marecatg for this detailed PR. I'll look to providing a patch release of sails-mongo to add maxPoolSize connection option.

Also I'll further investigate what other configs were deprecated as well and what else to add.

[DominusKelvin]

Hey @marecatg I just opened a PR to add the maxPoolSize config. This will be merged as soon as possible. Thanks for your patience on this one. cc @eashaw

[marecatg]

Thank you @DominusKelvin 🚀

[marecatg]

Hello, any news about the PR ? Thank you.

[DominusKelvin]

Hey @marecatg the PR has been merged that added the new pool size config to sails-mongo. There is also a new patch release as well.