Skip to content

Commit

Permalink
vss: call SetBackupState with bSelectComponents and bBackupBootableSy…
Browse files Browse the repository at this point in the history
…stemState again

We call the SetBackupState again like it was before commit

8b1c713 :
vss: Fix IVssBackupComponents::SetBackupState call

This commit changed the behaviour so that we experience problems when the
MS SqlServerWriter is installed on the system being backed up.

Fixes #768: Warning of failed VSS writer SqlServerWriter after 16.2 client upgrade.
  • Loading branch information
pstorz committed Feb 21, 2017
1 parent 14a0e1e commit c32be44
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions src/win32/filed/vss_generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -545,10 +545,12 @@ bool VSSClientGeneric::Initialize(DWORD dwContext, bool bDuringRestore)
break;
}

/*
* FIXME: need to support partial files - make last parameter true when done
*/
hr = pVssObj->SetBackupState(false, false, backup_type, false);
hr = pVssObj->SetBackupState(
true, /* bSelectComponents */
true, /* bBackupBootableSystemState */
backup_type, /* backupType */
false /* bPartialFileSupport */
);
if (FAILED(hr)) {
Dmsg1(0, "VSSClientGeneric::Initialize: IVssBackupComponents->SetBackupState returned 0x%08X\n", hr);
JmsgVssApiStatus(m_jcr, M_FATAL, hr, "SetBackupState");
Expand Down

2 comments on commit c32be44

@sur5r
Copy link

@sur5r sur5r commented on c32be44 Mar 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the removal of the comment about partial files intentional?

@pstorz
Copy link
Member Author

@pstorz pstorz commented on c32be44 Mar 29, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.