Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential executor simplification #131

Closed
kellytk opened this issue Dec 14, 2019 · 3 comments
Closed

Potential executor simplification #131

kellytk opened this issue Dec 14, 2019 · 3 comments

Comments

@kellytk
Copy link

kellytk commented Dec 14, 2019

Tokio is exploring Structured Concurrency Support. If that's informed by and ultimately accommodates the needs of Bastion its custom executor could potentially be removed.

@vertexclique
Copy link
Member

Thanks for your suggestion.
But there are couple of things that needs a spotlight:

  1. First this project is not an actor system. This is a runtime since the beginning.
  2. Tokio never have offered smth more general (Structured Concurrency Support tokio-rs/tokio#1879 (comment)) and never going to be. This project USED tokio before, while noone was implementing Erlang like runtime systems. Question comes in mind: "Where they have been?"
  3. Absorbing projects and completely copying approaches and their API is not a right approach. (It's easy to say "I didn't understand what it is" if you are copying over)
  4. We are using reduction based concurrency control with two phases locking on the current system at a time, and I think they have never heard this before. And I think they will copy that too.
  5. Vilification of what other people do (for example, Bastion project) by saying: "Tokio offers more" isn't right. There is no code existing yet at their side.
  6. Instead of derogatory comments, they can contact us and improve collaboration. We are open about it.
  7. We are not going to remove what is underneath Bastion. A lot of people put a lot of effort into making this, and even it wasn't our day job like Tokio developers. It contains enormous amount of energy and sweat. We aren't done yet. We have just started.

Sidenote for this issue:
Our executor design is way much more straightforward than Tokio's. If they want to care, they can learn from our designs. And I hope next time they can refer to what they are copying as API or code.

@kellytk
Copy link
Author

kellytk commented Dec 15, 2019

@vertexclique Being unfamiliar with both projects I'm unable to address most of your comment. My thought was that if Tokio's introducing a similar but more generic solution it could be useful to Bastion. Would you prefer that I close this issue?

@vertexclique
Copy link
Member

vertexclique commented Dec 15, 2019

Thank you for your suggestion. There is nothing wrong with your thinking and truly I appreciate that you opened this issue otherwise we won't be aware of this thing. We are implementing the issues that we have talked on lobste.rs and they were very helpful. I think you've already understood the Bastion. For this time of being I want to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants