Add generate_internal_visibility_from_proto_files feature #962
+39
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylervick
requested review from
BalestraPatrick,
brentleyjones,
keith,
segiddins and
thii
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
mattrobmattrob
requested changes
Feb 21, 2023
There was a problem hiding this comment.
Thanks for the addition, @tylervick!
Two things:
- Mind adding an example/validation of this flag similar to
//examples/xplatform/proto:example_path_to_underscores_protowithfeatures = ["swift. generate_internal_visibility_from_proto_files"]that validates this functionality? - Can you move the
//third_party/...formatting changes to a separate PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #961
Change
Create a new feature
swift.generate_internal_visibility_from_proto_fileswhich will set protoc's swift_optVisibilityfromPublictoInternal.Test
swift_grpc_libraryorswift_proto_libraryswift.generate_internal_visibility_from_proto_filesto thefeaturesattribute for the above ruleinternal)Note
The ideal solution would be to make the
Publicsetting opt-in for this feature, thereby mirroring default protoc Swift plugin behavior. Since rules_swift has always defaulted to public visibility this should instead remain the default.