Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Support for imposterRepository needs to be deeper. #763

Open
TetsujinOni opened this issue Apr 24, 2024 · 0 comments
Open

Async Support for imposterRepository needs to be deeper. #763

TetsujinOni opened this issue Apr 24, 2024 · 0 comments

Comments

@TetsujinOni
Copy link
Contributor

Expected behaviour

Async-first databases should be able to integrate with the mainline imposterRepository contract.

Actual behaviour

Most of the impsoterRepository contract is synchronous.

Steps to reproduce

Compare the imposterRepository contract test in this repo with the imposterRepository contract test in ibnc/mountebankMongo; the reported issues on that repo are because of the incompatible contract. The net result is errors when callsites expecting sync behavior receive a promise instead of the expected objects.

Desired Change

Furthering the move from the --datadir refactor so that imposterRepository is asynchronous so that promise-infected storage plugins are the default.

This will require work on the in-memory and datadir repository implementations, the callsites that consume the imposters, and tests.

Probably a wishlist or 2.11 target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant