Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial port configure misuse #1

Closed
maxatome opened this issue Dec 26, 2010 · 3 comments
Closed

Serial port configure misuse #1

maxatome opened this issue Dec 26, 2010 · 3 comments

Comments

@maxatome
Copy link

In lib/Device/RFXCOM/Base.pm, function _open_serial_port.

It is not correct to configure the serial port, then closing it to reopen it later. Perhaps it works on linux or windows, but it is just a "good" side-effect. Under any BSD platform, when you close a serial port, all its config is reset to its initial state. So this module don't work under BSD, except when I patch Base.pm to forget the use of Device::SerialPort and properly configure the port using POSIX::Termios just after the sysopen.

I can send you the patch I use under FreeBSD, if you want. I think it should work on Linux but I can't test it under windows...

Thank you for your work.

Best regards,

Max.

@beanz
Copy link
Owner

beanz commented Dec 27, 2010

Interesting. Thanks for this bug report. I'll try to fix this shortly.

@beanz
Copy link
Owner

beanz commented Jan 16, 2011

Fix committed. Should be okay on most unix systems now. Let me know if I've missed anyhing and/or if it doesn't work for you.

@maxatome
Copy link
Author

Hello,
sorry for the delay... It works like a charm under FreeBSD now :-)
Thanks a lot !
Max.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants