Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withNaming - default modifier's delimiter is undefined #561

Open
ViieeS opened this issue Jun 11, 2020 · 1 comment
Open

withNaming - default modifier's delimiter is undefined #561

ViieeS opened this issue Jun 11, 2020 · 1 comment

Comments

@ViieeS
Copy link

ViieeS commented Jun 11, 2020

Example

If I call it like this:

const cn = withNaming({e: '__'});
cn('bl')('el', { mod: 'val' });
// -> bl__elundefinedmodundefinedval

It only works if I explicitly specify the modifier

withNaming({e: '__', m: '_'});
@tadatuta
Copy link
Member

can be fixed with https://github.com/bem/bem-react/compare/issues/561?expand=1

but I don't think it should be fixed actually. as there's no such thing like default mod delimiter (there's default naming preset though) and providing such fallback will increase package size with almost no reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants