Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforced maker options limit configuration #225

Open
publicvirtualvoid opened this issue Jun 23, 2023 · 3 comments
Open

Enforced maker options limit configuration #225

publicvirtualvoid opened this issue Jun 23, 2023 · 3 comments

Comments

@publicvirtualvoid
Copy link

After some digging I realised that there are certain options for electron-builder that are hardcoded:

filter: ['main.js', '?(*.)preload.js', 'assets']

May I suggest that these are better generated as part of the default file itself such that the user still has the freedom to modify these?
In my case, I don't want to have my assets directory inside my .asar, so it is added as extraFiles.
I can't currently remove it from inclusion in the asar leading to them being included twice.

@bennymeg
Copy link
Owner

bennymeg commented Jul 8, 2023

Excluding (or requiring the user explicitly define) the assets folder might confuse some users that just expects their application to function.
I would suggest adding an additional folder (i.e. '_assets') which you be able to include as an extra instead.

@publicvirtualvoid
Copy link
Author

Would it not be better to include these in the default options file generated from the template? The application will function the same, but can be modified per application if needed.

@bennymeg
Copy link
Owner

bennymeg commented Jul 9, 2023

Sounds like a good compromise. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants