Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify partial_chain with custom ssl_options #654

Open
spydon opened this issue Aug 25, 2020 · 2 comments
Open

Verify partial_chain with custom ssl_options #654

spydon opened this issue Aug 25, 2020 · 2 comments
Assignees
Milestone

Comments

@spydon
Copy link
Contributor

spydon commented Aug 25, 2020

If I'm not mistaken it is not possible to use the default partial_chain option when using custom ssl_options in 1.16.0 since partial_chain/1 isn't exported anymore.
Or is there a possibility to merge custom ssl options with the default ones?

@benoitc
Copy link
Owner

benoitc commented Aug 25, 2020

check_hostname_opts/1is exported from hackney_ssl. Depending on what you need that maybe enough. I can provbably export the partial_chain callback if needed. What require your custom ssl options for now?

@spydon
Copy link
Contributor Author

spydon commented Aug 25, 2020

Thanks for the quick reply!
I think we mainly use a specific verify_fun and also swap cacerts to cacertfile in some cases.
The most useful would be if there was a way to use the hackney SSL defaults opts and then just override a few instead of all of them, is that possible somehow?

@benoitc benoitc added this to the 1.17.0 milestone Sep 11, 2020
@benoitc benoitc self-assigned this Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants