Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract proxy basic auth from URL #741

Open
Coffei opened this issue May 10, 2024 · 1 comment
Open

Extract proxy basic auth from URL #741

Coffei opened this issue May 10, 2024 · 1 comment
Assignees

Comments

@Coffei
Copy link

Coffei commented May 10, 2024

Since this library can automatically use ENV variables to set proxy, it would be cool if it could also set proxy basic auth, if it's present in the URL. We have a proxy ENV variable defined as HTTPS_PROXY=http://user:password@proxy.example.com:80/. I checked the code and it seems while proxy is configured from both explicit configuration options and ENV, proxy auth is only configured via explicit config options.

@benoitc benoitc self-assigned this May 10, 2024
@benoitc
Copy link
Owner

benoitc commented May 10, 2024

I will add this support in #737 . Thanks for the suggestion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants