Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for node configuration in graph editor #237

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Oct 4, 2023

  1. account for node configuration in graph editor

    The objective of this commit is to correctly render graphs like these:
    https://github.com/bhouston/behave-graph/blob/3e6568caa9a46a6f6aee27b0192a478f30c9c541/graphs/core/flow/WaitAll.json
    
    When loading JSON, a node may have arbitrary configuration parameters,
    that previously got ignored (such as number of sequence outputs).
    
    This commit tracks configuration for each rendered node,
    and accounts for it in all calculations (such as adding new edge).
    
    In order to do this, instead of NodeSpecJSON (object) we now pass
    a NodeSpecGenerator (class) which generates node specs on demand
    based on passed configuration (and also memoizes, not sure if that's
    necessary).
    
    New nodes will still be generated with no configuration,
    and no UI work to support it has been done.
    rlidwka committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    3d2383d View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Configuration menu
    Copy the full SHA
    8fc8867 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. rename numInputs, numOutputs, numCases to numSockets

    and use generic interface to add new sockets for all of them
    rlidwka committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    32cfa2d View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    3a64025 View commit details
    Browse the repository at this point in the history