Qt: Add Android packaging support #17227

icota · 2019-10-23T13:41:55Z

This PR is the third and final piece of the basic Android support puzzle - it depends on #16110 and is related to #16883. It introduces an android directory under qt and a simple way to build an Android package of bitcoin-qt:

Build depends for Android as described in the README
Configure with one of the resulting prefixes
Run make && make apk in src/qt

The resulting APK files will be in android/build/outputs/apk. You can install them manually or with adb. One can also open the android directory in Android Studio for that integrated development and debugging experience. BitcoinQtActivity is your starting point.

Under the hood makefile apk target:

Renames the bitcoin-qt binary to libbitcoin-qt.so and copies it over to a folder under android/libs depending on which prefix and corresponding ABI bitcoin-qt was built for
Takes libc++_shared.so from the Android NDK and puts in the same place. It must be included in the APK
Extracts Qt for Android Java support files from the qtbase archive in depends/sources to android/src

There is also just a tiny bit of ifdef'd code to make the Qt Widgets menus usable. It's not pretty but it works and is a stepping stone towards #16883.

DrahtBot · 2019-10-23T14:30:24Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

build, qt: Fix static builds on macOS Big Sur #21495 (build, qt: Fix static builds on macOS Big Sur by hebasto)
guix: Use pigz as a faster gzip replacement #21478 (guix: Use pigz as a faster gzip replacement by dongcarl)
guix: Add guix-{attest,verify} scripts #21462 (guix: Add guix-{attest,verify} scripts by dongcarl)
build, qt: No longer need to patch translation.pro #21420 (build, qt: No longer need to patch translation.pro by hebasto)
guix: Misc feedback-based fixes + hier restructuring #21375 (guix: Misc feedback-based fixes + hier restructuring by dongcarl)
guix: Add guix-clean script + establish gc-root for container profiles #21304 (guix: Add guix-clean script + establish gc-root for container profiles by dongcarl)
build: macOS toolchain bump #19817 (build: macOS toolchain bump by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

laanwj · 2019-10-24T18:37:51Z

Concept ACK, nice !

icota · 2019-11-04T15:03:08Z

Rebased, squashed, added instructions under doc and updated the first comment to reflect that #16110 has been merged.

doc/package-android.md

luke-jr · 2019-11-04T16:30:49Z

This PR is the third and final piece of the basic Android support puzzle

IMO final would be a gitian descriptor ;)

adamjonas · 2020-05-01T01:01:31Z

@icota Friendly ping for a rebase.

icota · 2020-05-02T10:36:21Z

Thank you @adamjonas. Rebased.

maflcko · 2020-05-02T20:31:33Z

@icota Could you pull in maflcko@a0b441b to shave off a few kB off of the compressed images?

icota · 2020-05-03T09:15:09Z

Absolutely. Thanks @MarcoFalke

maflcko · 2020-05-03T11:05:50Z

Oh, you'll have to squash it. Otherwise git will keep track of both versions, thus doubling the size.

icota · 2020-05-03T12:24:19Z

Done.

BlockMechanic · 2020-05-18T22:12:26Z

Awesome, will test this out.

jonasschnelli · 2020-05-29T07:44:47Z

utACK a818b2c

maflcko · 2020-05-29T16:00:31Z

Concept ACK. Not sure how this can be tested in ci. I guess it needs the android dev kit?

icota · 2020-05-30T00:12:57Z

Yep it needs the SDK. Travis seems to support this.

maflcko · 2020-05-31T00:35:29Z

Unfortunately (or luckily) we can't use travis' packages. We use our own ci setup in ./ci.

The sdkmanager is a zip file that can be downloaded, though. And then a one-liner like

$ANDROID_HOME/tools/bin/sdkmanager --sdk_root=$ANDROID_HOME "platform-tools" "platforms;android-28" "ndk-bundle"

should do the rest.

jonasschnelli · 2020-06-05T07:47:29Z

I'd like to give this a try in the main branch (even without CI support). If it gets unmaintained, a revert is likely.
Anyone with Android experience willing to test this @Sjors, @hebasto, @promag, @greenaddress?

maflcko · 2021-03-24T07:33:51Z

cr ACK 246774e

laanwj · 2021-03-24T18:00:26Z

Code review ACK 246774e

ghost · 2021-03-24T18:50:59Z

#16883 is an attempt to make the GUI a bit more modern and usable but it's parked for now as I can't find the time to work on it.

@icota Thanks for working on this. Its merged :) #16883 looks interesting except one comment from @promag , my younger brother is also good with Android development but Kotlin. Will share things with him after testing.

ryanofsky · 2021-03-24T23:27:32Z

Seeing CI failures in ARM64 Android APK [bionic] build that might be related to this:

https://cirrus-ci.com/task/5511109198217216?command=ci#L4420
https://cirrus-ci.com/task/5967779246374912?command=ci#L4426

make[1]: Entering directory '/tmp/cirrus-ci-build/src'
tar: --exclude=*/*: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
tar: --exclude=*/*: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
tar: --exclude=*/*: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
mkdir -p qt/android/libs/arm64-v8a
cp /tmp/cirrus-ci-build/depends/SDKs/android/ndk/21.1.6352462/toolchains/llvm/prebuilt/linux-x86_64/bin//../sysroot/usr/lib/aarch64-linux-android/libc++_shared.so qt/android/libs/arm64-v8a
tar xf  -C qt/android/src/ src/android/jar/src --strip-components=5
tar: -C: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
Makefile:15443: recipe for target 'bitcoin_qt_apk' failed

icota · 2021-03-25T07:28:22Z

@ryanofsky Yes, and this line is the culprit:

bitcoin/src/Makefile.qt.include

Line 382 in 9217f9f

    
           QT_BASE_PATH = $(shell find ../depends/sources/ -maxdepth 1 -type f -regex ".*qtbase.*\.tar.xz")

Is Cirrus perhaps wiping depends/sources from time to time?

achow101 · 2021-03-25T17:20:03Z

Is Cirrus perhaps wiping depends/sources from time to time?

I'm able to reproduce a similar error locally so I don't think it is a cirrus issue.

icota · 2021-03-25T19:56:31Z

I can't reproduce locally (unless I manually delete sources) but I'm seeing a pattern on the latest runs:

fails when run last:
https://github.com/bitcoin/bitcoin/pull/21392/checks
https://github.com/bitcoin/bitcoin/pull/16545/checks
https://github.com/bitcoin/bitcoin/pull/19460/checks

succeds otherwise:
https://github.com/bitcoin/bitcoin/pull/21422/checks
https://github.com/bitcoin/bitcoin/pull/21526/checks
https://github.com/bitcoin/bitcoin/pull/17227/checks

I'm drawing a blank here and I am also fine with disabling the CI APK build for the time being.

icota · 2021-03-28T08:45:03Z

Trying to fix the issue in #21537

icota · 2021-03-28T17:42:57Z

Fixed by @MarcoFalke in #21541

hebasto · 2021-05-25T19:20:09Z

src/Makefile.qt.include

@@ -378,6 +378,20 @@ bitcoin_qt_clean: FORCE

 bitcoin_qt : qt/bitcoin-qt$(EXEEXT)

+APK_LIB_DIR = qt/android/libs/$(ANDROID_ARCH)


Shouldn't the content of the qt/android directory be a subject of the cleanup in make clean or make distclean?

It should 👍

hebasto · 2021-12-03T00:33:40Z

src/qt/android/src/org/bitcoincore/qt/BitcoinQtActivity.java

+        final File bitcoinDir = new File(getFilesDir().getAbsolutePath() + "/.bitcoin");
+        if (!bitcoinDir.exists()) {
+            bitcoinDir.mkdir();
+        }


This code prevents the Intro dialog from showing at the first startup. Is it intended? If yes, why?

TBH I don't remember why I did this. Did you try without it? Maybe the dialog was showing incorrectly?

I didn't at the time but I realise now that this makes using external storage impossible. Possibly related to bitcoin-core/gui#496

hebasto · 2021-12-05T21:53:51Z

After bumping Qt to 5.15.2 (#23489) this stuff seems required to be updated to work properly.
Massive changes were done in Qt 5.14 (e.g., qt/qtbase@5bb178c).

@icota Could you have a look into this please?

hebasto · 2021-12-06T21:23:10Z

After bumping Qt to 5.15.2 (#23489) this stuff seems required to be updated to work properly. Massive changes were done in Qt 5.14 (e.g., qt/qtbase@5bb178c).

@icota Could you have a look into this please?

https://www.kdab.com/qt-for-android-better-than-ever-before/ seems related.

icota · 2021-12-12T08:10:22Z

Thanks for letting me know @hebasto. Attempting to fix the issues in bitcoin-core/gui#504

merge bitcoin#17227...bitcoin#23580: Qt 5.12.10

fanquake added the Android label Oct 23, 2019

icota mentioned this pull request Oct 23, 2019

depends: Add Android NDK support #16110

Merged

laanwj added the GUI label Oct 24, 2019

laanwj requested review from theuni and dongcarl October 25, 2019 10:03

icota force-pushed the qt-android-package branch from fc5bea0 to d5f83c5 Compare November 4, 2019 14:58

maflcko reviewed Nov 4, 2019

View reviewed changes

doc/package-android.md Outdated Show resolved Hide resolved

icota force-pushed the qt-android-package branch from d5f83c5 to 533c18d Compare November 4, 2019 15:47

DrahtBot added the Needs rebase label Feb 10, 2020

icota force-pushed the qt-android-package branch from 533c18d to 078078a Compare May 2, 2020 10:33

DrahtBot removed the Needs rebase label May 2, 2020

icota force-pushed the qt-android-package branch from 67441a9 to a818b2c Compare May 3, 2020 12:20

maflcko mentioned this pull request May 5, 2020

Move optimize-pngs.py script from Bitcoin Core repo bitcoin-core/bitcoin-maintainer-tools#56

Merged

fanquake mentioned this pull request May 27, 2020

doc: Separate repository for the gui #19071

Merged

laanwj merged commit 23b1560 into bitcoin:master Mar 24, 2021

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 24, 2021

Merge bitcoin#17227: Qt: Add Android packaging support

8a273cf

ryanofsky mentioned this pull request Mar 28, 2021

ci: Build depends only once for Android build #21541

Merged

hebasto reviewed May 25, 2021

View reviewed changes

kwvg added a commit to kwvg/dash that referenced this pull request Nov 24, 2021

merge bitcoin#17227: Add Android packaging support

bd83a80

kwvg added a commit to kwvg/dash that referenced this pull request Nov 25, 2021

merge bitcoin#17227: Add Android packaging support

5fe57a5

hebasto reviewed Dec 3, 2021

View reviewed changes

kwvg added a commit to kwvg/dash that referenced this pull request Dec 12, 2021

merge bitcoin#17227: Add Android packaging support

a596677

kwvg added a commit to kwvg/dash that referenced this pull request Jan 12, 2022

merge bitcoin#17227: Add Android packaging support

0217aaa

kwvg added a commit to kwvg/dash that referenced this pull request Feb 7, 2022

merge bitcoin#17227: Add Android packaging support

b7eb580

kwvg added a commit to kwvg/dash that referenced this pull request Feb 17, 2022

merge bitcoin#17227: Add Android packaging support

7339525

kwvg added a commit to kwvg/dash that referenced this pull request Feb 18, 2022

merge bitcoin#17227: Add Android packaging support

bf3b2c7

kwvg added a commit to kwvg/dash that referenced this pull request Apr 25, 2022

merge bitcoin#17227: Add Android packaging support

37a5bd0

kwvg added a commit to kwvg/dash that referenced this pull request Apr 25, 2022

merge bitcoin#17227: Add Android packaging support

30fafdc

kwvg added a commit to kwvg/dash that referenced this pull request Apr 26, 2022

partial bitcoin#17227: Add Android packaging support

ae45b57

UdjinM6 added a commit to dashpay/dash that referenced this pull request Apr 26, 2022

Merge pull request #4581 from kittywhiskers/monterey_patch

cb75351

merge bitcoin#17227...bitcoin#23580: Qt 5.12.10

kwvg pushed a commit to kwvg/dash that referenced this pull request Oct 16, 2022

merge bitcoin#17227: Add Android packaging support

1e3cd31

bitcoin locked and limited conversation to collaborators Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Qt: Add Android packaging support #17227

Qt: Add Android packaging support #17227

icota commented Oct 23, 2019 •

edited

DrahtBot commented Oct 23, 2019 •

edited

laanwj commented Oct 24, 2019

icota commented Nov 4, 2019

luke-jr commented Nov 4, 2019

adamjonas commented May 1, 2020

icota commented May 2, 2020

maflcko commented May 2, 2020

icota commented May 3, 2020

maflcko commented May 3, 2020

icota commented May 3, 2020

BlockMechanic commented May 18, 2020

jonasschnelli commented May 29, 2020

maflcko commented May 29, 2020

icota commented May 30, 2020

maflcko commented May 31, 2020

jonasschnelli commented Jun 5, 2020

maflcko commented Mar 24, 2021

laanwj commented Mar 24, 2021

ghost commented Mar 24, 2021

ryanofsky commented Mar 24, 2021 •

edited

icota commented Mar 25, 2021 •

edited

achow101 commented Mar 25, 2021 •

edited

icota commented Mar 25, 2021

icota commented Mar 28, 2021

icota commented Mar 28, 2021

hebasto May 25, 2021

icota May 26, 2021

hebasto Dec 3, 2021

icota Dec 4, 2021

hebasto commented Dec 5, 2021

hebasto commented Dec 6, 2021

icota commented Dec 12, 2021

		@@ -378,6 +378,20 @@ bitcoin_qt_clean: FORCE

		bitcoin_qt : qt/bitcoin-qt$(EXEEXT)

		APK_LIB_DIR = qt/android/libs/$(ANDROID_ARCH)

Qt: Add Android packaging support #17227

Qt: Add Android packaging support #17227

Conversation

icota commented Oct 23, 2019 • edited

DrahtBot commented Oct 23, 2019 • edited

Conflicts

laanwj commented Oct 24, 2019

icota commented Nov 4, 2019

luke-jr commented Nov 4, 2019

adamjonas commented May 1, 2020

icota commented May 2, 2020

maflcko commented May 2, 2020

icota commented May 3, 2020

maflcko commented May 3, 2020

icota commented May 3, 2020

BlockMechanic commented May 18, 2020

jonasschnelli commented May 29, 2020

maflcko commented May 29, 2020

icota commented May 30, 2020

maflcko commented May 31, 2020

jonasschnelli commented Jun 5, 2020

maflcko commented Mar 24, 2021

laanwj commented Mar 24, 2021

ghost commented Mar 24, 2021

ryanofsky commented Mar 24, 2021 • edited

icota commented Mar 25, 2021 • edited

achow101 commented Mar 25, 2021 • edited

icota commented Mar 25, 2021

icota commented Mar 28, 2021

icota commented Mar 28, 2021

hebasto May 25, 2021

Choose a reason for hiding this comment

icota May 26, 2021

Choose a reason for hiding this comment

hebasto Dec 3, 2021

Choose a reason for hiding this comment

icota Dec 4, 2021

Choose a reason for hiding this comment

hebasto commented Dec 5, 2021

hebasto commented Dec 6, 2021

icota commented Dec 12, 2021

icota commented Oct 23, 2019 •

edited

DrahtBot commented Oct 23, 2019 •

edited

ryanofsky commented Mar 24, 2021 •

edited

icota commented Mar 25, 2021 •

edited

achow101 commented Mar 25, 2021 •

edited