-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/rabbitmq-cluster-operator] metrics-endpoint serviceMonitor references missing port #25743
Comments
Maybe also the author @basit9958 of the change dceeb50 could add their two cents on this one. |
This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback. |
Before this get's stale, I'll try to come up with a pull request in the next days. Would be great to get input on this one beforehand. |
Hi, I believe that the metrics endpoint references the RabbitMQ instances created by the operator. It's not clear to me whether the selector actually matches the created instances. |
…itnami#25743) Signed-off-by: Tolleiv Nietsch <github@tolleiv.de>
The RabbitMQ instances do not have |
Thank you for opening this issue and submitting the associated Pull Request. Our team will review and provide feedback. Once the PR is merged, the issue will automatically close. Your contribution is greatly appreciated! |
#26601) * [bitnami/rabbitmq-cluster-operator] Remove operator metrics endpoint (#25743) Signed-off-by: Tolleiv Nietsch <github@tolleiv.de> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> --------- Signed-off-by: Tolleiv Nietsch <github@tolleiv.de> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com> Signed-off-by: Fran Mulero <fmulero@vmware.com> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com> Co-authored-by: Fran Mulero <fmulero@vmware.com>
Name and Version
bitnami/rabbitmq-cluster-operator 4.2.8
What architecture are you using?
amd64
What steps will reproduce the bug?
Release the chart with it's default values and monitoring enabled.
helm template rabbitmq-cluster-operator "oci://registry-1.docker.io/bitnamicharts/rabbitmq-cluster-operator" --version 4.2.8 --set clusterOperator.metrics.serviceMonitor.enabled=true --set clusterOperator.metrics.service.enabled=true --namespace=demo
The rendered resources include a ServiceMonitor with two endpoints:
where the related Deployment only has a single port:
Are you using any custom parameters or values?
clusterOperator.metrics.serviceMonitor.enabled=true
clusterOperator.metrics.service.enabled=true
What is the expected behavior?
The ServiceMonitor should only reference existing ports.
What do you see instead?
The
metrics
Port is part of the ServiceMonitor without being present on the Deployment.Additional information
The second port was introduce in dceeb50 - maybe a feature flag should be added or some more documentation.
The text was updated successfully, but these errors were encountered: