Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/mongodb] Allow templating for initdbScriptsConfigMap #25966

Closed
AzHicham opened this issue May 17, 2024 · 3 comments · Fixed by #26324
Closed

[bitnami/mongodb] Allow templating for initdbScriptsConfigMap #25966

AzHicham opened this issue May 17, 2024 · 3 comments · Fixed by #26324
Assignees

Comments

@AzHicham
Copy link
Contributor

AzHicham commented May 17, 2024

Name and Version

bitnami/mongodb 15.4.3

What is the problem this feature will solve?

Right now it's not possible to do the following:

mongodb:
  initdbScriptsConfigMap: '{{ include "common.names.fullname" $ }}-configmap'

Because according to this code no templating is allowed.

Without this possibility the configmap name must be hardcoded.

What is the feature you are proposing to solve the problem?

A simple solution is to change in the code the following line :
{{- printf "%s" .Values.initdbScriptsConfigMap -}}
by this one
{{- printf "%s" (tpl .Values.initdbScriptsConfigMap $) -}}

tpl is often used in bitnami charts (postgresql, even in mongodb chart) in order to allow this kind of templating

What alternatives have you considered?

No response

@javsalgar
Copy link
Contributor

Hi!

Thank you so much for the feature request. I will forward it to the team, but as it is not a critical feature, we cannot guarantee an ETA. If you want to speed up the process, would you like to submit a PR adding this feature?

@AzHicham AzHicham changed the title [bitnami/redis] Allow templating for initdbScriptsConfigMap [bitnami/mongodb] Allow templating for initdbScriptsConfigMap May 21, 2024
@AzHicham
Copy link
Contributor Author

Hello,
I'll try to create a PR asap :)

@carrodher
Copy link
Member

Thank you for opening this issue and submitting the associated Pull Request. Our team will review and provide feedback. Once the PR is merged, the issue will automatically close.

Your contribution is greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants