Use standard/built-in types instead of local typedefs where possible #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since stdint.h was added in C99, pass the required C standard to the compiler explicitly, and do the same for C++ standard along the way.
As we're using std int types (since previous commit), use corresponding std format macros to avoid potential format specifier mismatches.
MSDN states that SSIZE_T is defined as LONG_PTR, and LONG_PTR is defined as long (32-bit) when building for x86 and __int64 (64-bit) when building for x64, which basically means that it's signed and its size matches that of a pointer, which in turn is the definition of intptr_t. The latter is provided by stdint.h which we're already including.
This avoids potential clashes as the name is way too common.
This avoids potential clashes as the name is way too common.
This avoids potential clashes as the name is way too common.
This avoids potential clashes as the name is way too common.
This header is C99 and we can use it since we're already using stdint.h and inttypes.h anyway. It also helps to avoid clashes when other code that uses this library includes stdbool.h.
|
I'm adding |
Most probably not all the places were covered, some more work (unrelated to these changes) needs to be done.
mikedld
force-pushed
the
feature/std-types
branch
from
867088b
to
54851c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes most of manually defined types in utp_types.h in favor of either standard integral types defined as part of C99, or built-in basic types, which reduces the chances of clashes with other code since the names were quite generic/common. All the changes here are done with dull find/replace, please do tell if there're any formatting issues or whatnot that you'd like me to fix.
Fixes: #122
Overlaps with: #70