Template instances can't override the flipped states into the gid of the template #1895
Comments
This is not the full story, right? I tried to reproduce this but it seemed to work fine. When I tried saving and loading the map though, I noticed the flipped state was not getting saved. This is probably because an override flag is not getting set. That flag does affect the tile + flipped states though, so when you flip the tile of a template object, it will also override the tile.
Unless you really need to override only the flipping bits, I would suggest not making this more complicated than necessary for now. I do agree it's rather unintuitive, so we could consider changing this... the approach you're suggesting doesn't sound bad. |
|
Hmm, after fixing the setting of the changed flag, it still didn't work (would write out In my case the tileset was part of the map as well though, which probably indicates another bug... |
Ok, that is because tilesets that are part of the map do not get added to the tileset manager until after the map is loaded, so once it encounters the same tileset while loading a template it will not find it there and it will load it again. This is getting rather tricky... probably the reference counting of tilesets should be moved from |
FIXME: The flag should not be set when ChangeMapObjectCells is used in AdjustTileIndexes. Issue #1895
Yes, sorry for not being totally clear here, indeed it does not get saved and loses it states when closing and loading the map again.
It's a bad thing the gid="0"? If keeping only the flipped states in the object's gid, the global ID isn't really needed. |
Oh, I see, it will always override the flipped states with false values. It really is tricky, maybe omitting the gid attribute when there's no change in the flipped states. And when there's the gid, get it and override the states bits. |
Related to issue #1895. However, it does not fix the whole problem, since in fact a "gid" can't be written for template objects that use a tile from a tileset that isn't also part of the map. In addition, there is a caching issue causing tilesets used by both templates and the map to get loaded twice. This is why it currently won't even work for loaded maps, even if the tileset used by the template is part of the map as well.
Rely on the QSharedPointer for the lifetime and add/remove tilesets instances from the TilesetManager directly from the Tileset class. This fixes issues with tilesets getting loaded twice when they are used by both a map and a template object, which happened as a result of the manual adding of references being too late. In general this approach should also be more reliable and prevent double loading of tilesets in some cases. Helps with issue #1895 when the tileset used by the template is also part of the map.
|
I've made some changes (see above) that will be included with Tiled 1.1.3 which fix this issue in case the tileset used by the template is also part of the map. Though the whole gid will be overridden in this case, not just the flipping flags. I think changing the behavior such that you could override only the flipping bits is outside the scope of a patch release, but I'll leave this issue open since we could consider this for Tiled 1.2. |
ghost
closed this as 
When using templates of tile object, the flipped states can only be set in the template and cannot be changed in the object.
You can reproduce it by creating a template and trying to modify a instance's flipped states.
I`m not sure of a way to solve this, maybe keeping a gid attribute with only the flipped states in the object, but when reading you'll need to pay attention and use the tile from the template and not the nonexistent tile 0 (zero) from the object. (which is fine for me)
The text was updated successfully, but these errors were encountered: