Rust: questions and comments

[jblachly]

1. is bkind necessary in the Coordinates type
2. Would rename Coordinates to Interval
3. Should to be into?

[charlesgregory]

With latest commits questions 1 and 2 are addressed.
As for question 3:
The rust API guidelines on conversion state:

Conversions prefixed as_ and into_ typically decrease abstraction, either exposing a view into the underlying representation (as) or deconstructing data into its underlying representation (into).

Conversions prefixed to_, on the other hand, typically stay at the same level of abstraction but do some work to change from one representation to another.

So I think to is appropriate.

[jblachly]

So I re-read the linked page (which incidentally I could only find by coming back here, no matter what combinatin of google search terms I used, I couldn't find it again :/) and something stands out, namely that into is for owned->owned, and will consume the input.

That looks exactly like what your functions are doing:

impl Interval<ZeroBased, HalfOpen>{
    pub fn to<ToBs: Basis, ToEd: End>(&self) -> Interval<ToBs, ToEd>{
        let mut ret = Interval::<ToBs, ToEd>::from_int(self.start.pos, self.end.pos);
        if !ToBs::IS_ZERO_BASED {
            ret.start.pos += 1;
            ret.end.pos += 1;
        }
        if !ToEd::IS_EXCLUSIVE {
            ret.end.pos -= 1;
        }
        ret
    }
}