Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop not working #14

Open
mumbaimerijaan opened this issue Dec 5, 2017 · 4 comments
Open

Stop not working #14

mumbaimerijaan opened this issue Dec 5, 2017 · 4 comments

Comments

@mumbaimerijaan
Copy link

Stop not working...
When I checked I found that all timeouts are not removed, hence when reloading the page in the iframe I am getting an error.

To solve this, I passed the timeout id to the function called in setTimeout, and then cleared the timeout promptly.
Please make this change to the original code, so that others will be benefited.

@blaiprat
Copy link
Owner

blaiprat commented Dec 6, 2017

Hi @mumbaimerijaan , thanks for opening the issue.

Since it's Christmas I might not have enough free time, do you mind providing a PR for this code please?

Thanks!

@mumbaimerijaan
Copy link
Author

mumbaimerijaan commented Dec 9, 2017 via email

@CorentinVv
Copy link

Hey ! Thank you for your script !
Loop and autoplay are not working for me, do you know how to solve this please ?

Regards.

@CorentinVv
Copy link

Sorry am new to github.. what's a PR? Regards, Sachin

On Dec 6, 2017 7:29 PM, "Blai Pratdesaba" @.***> wrote: Hi @mumbaimerijaan https://github.com/mumbaimerijaan , thanks for opening the issue. Since it's Christmas I might not have enough free time, do you mind providing a PR for this code please? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AHIiqrtr4Qvjc5lbI9iyy6Mhz_FfR6RHks5s9p2lgaJpZM4Q2hRt .

PR is a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants