Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split boa_tester into crates #3696

Open
jedel1043 opened this issue Feb 27, 2024 · 2 comments · May be fixed by #3708
Open

Split boa_tester into crates #3696

jedel1043 opened this issue Feb 27, 2024 · 2 comments · May be fixed by #3708
Labels
E-Medium Medium difficulty problem Internal Category for changelog test Issues and PRs related to the tests.

Comments

@jedel1043
Copy link
Member

jedel1043 commented Feb 27, 2024 •
edited

Now that temporal_rs is a thing, we need a way to test it against test262. We could reimplement boa_tester but it would be better to extract the test extraction part from the test runner, and then reuse that for temporal_rs.
@jedel1043 jedel1043 added E-Easy Easy Internal Category for changelog test Issues and PRs related to the tests. E-Medium Medium difficulty problem and removed E-Easy Easy labels Feb 27, 2024
@PawelJastrzebski PawelJastrzebski linked a pull request Feb 29, 2024 that will close this issue
Open
@PawelJastrzebski
Copy link

Hi, I would like to contribute. Could you tell me if I'm going in the right direction?

I'm not sure if I'm understanding use case for this new crate, you want to extract all parsing logic from boa_tester to another crate so extraction/parsing logic could be reused. I'm not sure if I understand "extraction part" correctly.

image
test262-parser (todo typo) representing new crate

@jedel1043
Copy link
Member Author

@PawelJastrzebski Thank you for the help! Yeah, that was mostly the idea: separate the test262 parser from the main program. Though, I'd recommend also including the git module inside test262_parser, maybe with some interface to be able to either download the repo or pass a manual path to a valid test262 directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-Medium Medium difficulty problem Internal Category for changelog test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3696 - tc39-test262 Crate PawelJastrzebski/boa-fork
2 participants
@PawelJastrzebski @jedel1043