Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text-area overflow issue safari #15

Open
ph101pp opened this issue Mar 21, 2016 · 0 comments
Open

Text-area overflow issue safari #15

ph101pp opened this issue Mar 21, 2016 · 0 comments

Comments

@ph101pp
Copy link
Member

ph101pp commented Mar 21, 2016

https://dowjones.slack.com/files/adrian/F0UBPF464/pasted_image_at_2016_03_21_05_00_pm.png

Adrian Lafond [17:01]
no idea if this is a safari bug, bonaparte weirdness, something i did, but in safari text is escaping the bounds of a textarea

overflow: hidden; fixes it but of course i need it to scroll
haven’t dug that deep into it, it was only reported to me 5 minutes ago
found the cause: display: table-row-group;

[17:05]
which it inherits from

.ui.form input:not([type]),
.ui.form input[type=text],
.ui.form input[type=email],
.ui.form input[type=search],
.ui.form input[type=password],
.ui.form input[type=date],
.ui.form input[type=datetime-local],
.ui.form input[type=tel],
.ui.form input[type=time],
.ui.form input[type=url],
.ui.form input[type=number],
.ui.form textarea {
    width: 100%;
    border: 0;
    border-bottom: 3px double #E0E0E0;
    background-color: #FAFAFA;
    padding: 1rem;
    font-size: 1.3rem;
    color: #1A1A1A;
    outline: none;
    display: table-row-group;
}

so that’s a safari bug, since the text should never overflow the textarea like that
nevertheless

Philipp Adrian [17:07]
that would be the place to add the overflow:hidden

Adrian Lafond [17:10]
display: block fixes it, but what is table-row-group supposed to do that is better?`

overflow: hidden isn’t actually what we want to do since users need to scroll the content in there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant