Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group checkboxes can all be removed because of limited per-group access settings #142

Open
boonebgorges opened this issue Jan 27, 2017 · 0 comments

Comments

@boonebgorges
Copy link
Owner

The logic for rendering the group checkboxes on the Send Invites page looks like this:

if ( bp_has_groups... ) {
    echo 'Header';
    while ( bp_groups() ) : bp_the_group();
        if ( ! bp_groups_user_can_send_invites( bp_get_group_id() ) || 'anyone' !== invite_anyone_group_invite_access_test( bp_get_group_id() ) ) {
            continue;
        }
    endwhile;
}

If every group matched by bp_has_groups() is skipped because of the more specific settings check, you can end up with an empty section. This is a bad user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant