Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting targets with cmake #569

Open
ropieur opened this issue Mar 27, 2023 · 0 comments
Open

Conflicting targets with cmake #569

ropieur opened this issue Mar 27, 2023 · 0 comments

Comments

@ropieur
Copy link

ropieur commented Mar 27, 2023

Expected Behavior

Integration of sml as 3rdparty library shouldn't lead to cmake targets conflicts

Actual Behavior

The integration of sml with cmake leads to a conflict target "logging" from the examples which is enough generic to potentially conflict within an existing large project.

I would expect to control cmake targets with options SML_BUILD_EXAMPLES set to OFF. But the inclusion of examples is not conditioned by this flag. I would suggest to include examples only if SML_BUILD_EXAMPLES=ON. The same reasoning could apply to other flags SML_BUILD_BENCHMARKS and SML_BUILD_TESTS

Specifications

  • Version: 1.1.6
  • Platform: Ubuntu 22.04
  • Subsystem:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant