Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert cc019f75 #829

Open
vinniefalco opened this issue Dec 28, 2022 · 0 comments
Open

revert cc019f75 #829

vinniefalco opened this issue Dec 28, 2022 · 0 comments
Assignees
@grisumbras

Comments

@vinniefalco
Copy link
Member

The commit cc019f7 changes a bunch of code into enormous macros, presumably so that file and line number information is more correcterer. While this might have been useful in that moment, we now have the problem that the debugger is not capable of getting a breakpoint at code inside the macro and stepping through it. As I have a failure occurring at code inside the macro, I cannot debug it effectively.

This change needs to be reverted. There is an alternate solution for getting better diagnostics from failing tests, which I will open as another issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grisumbras grisumbras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vinniefalco @grisumbras